Signal chrome_elf to initialize crash reporting, rather than doing it in DllMain

chrome_elf/chrome_elf_main.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_elf/chrome_elf_main.h"
 
 #include <windows.h>
 #include <algorithm>
 
 #include "base/lazy_instance.h"
@@ skipping 66 matching lines @@
 void DisableSetUnhandledExceptionFilter() {
   DWORD patched = g_set_unhandled_exception_filter.PatchFromModule(
       GetModuleHandle(nullptr), "kernel32.dll", "SetUnhandledExceptionFilter",
       SetUnhandledExceptionFilterPatch);
   CHECK(patched == 0);
 }
 #endif // !defined(ADDRESS_SANITIZER)
 
 }  // namespace
 
+// This function is a temporary workaround for https://crbug.com/655788. We
+// need to come up with a better way to initialize crash reporting that can
+// happen inside DllMain().
+void SignalInitializeCrashReporting() {
+  InitializeCrashReportingForProcess();
+}
+
 void SignalChromeElf() {
   blacklist::ResetBeacon();
 }
 
 // This helper is invoked by code in chrome.dll to retrieve the crash reports.
 // See CrashUploadListCrashpad. Note that we do not pass an std::vector here,
 // because we do not want to allocate/free in different modules. The returned
 // pointer is read-only.
 extern "C" __declspec(dllexport) void GetCrashReportsImpl(
     const crash_reporter::Report** reports,
     size_t* report_count) {
   crash_reporter::GetReports(g_crash_reports.Pointer());
   *reports = g_crash_reports.Pointer()->data();
   *report_count = g_crash_reports.Pointer()->size();
 }
 
 // This helper is invoked by debugging code in chrome to register the client
 // id.
 extern "C" __declspec(dllexport) void SetMetricsClientId(
     const char* client_id) {
   if (client_id)
     crash_keys::SetMetricsClientIdFromGUID(client_id);
 }
 
 BOOL APIENTRY DllMain(HMODULE module, DWORD reason, LPVOID reserved) {
   if (reason == DLL_PROCESS_ATTACH) {
-    InitializeCrashReportingForProcess();
-    // CRT on initialization installs an exception filter which calls
-    // TerminateProcess. We need to hook CRT's attempt to set an exception
-    // handler and ignore it. Don't do this when ASan is present, or ASan will
-    // fail to install its own unhandled exception filter.
 #if !defined(ADDRESS_SANITIZER)
     DisableSetUnhandledExceptionFilter();
 #endif
 
     install_static::InitializeProcessType();
 
     __try {
       blacklist::Initialize(false);  // Don't force, abort if beacon is present.
     } __except(GenerateCrashDump(GetExceptionInformation())) {
     }
   }
   return TRUE;
 }