Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 2431473003: Intersection Observer support for OOPIF (Closed)
Patch Set: Addressed dcheng comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 9ab3a0a81e75eaf26acc7f379859d0e9140d532b..eb63520b55256306945b16e67c44f8c63acb8c59 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -725,6 +725,17 @@ void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range) {
}
}
+void WebFrameWidgetImpl::setRemoteViewportIntersection(
+ const WebRect& viewportIntersection) {
+ // Remote viewports are only applicable to local frames with remote ancestors.
+ if (!m_localRoot->parent() || !m_localRoot->parent()->isWebRemoteFrame())
dcheng 2017/01/12 11:32:08 I would expect content to not send us the message
kenrb 2017/01/12 19:51:27 Done.
+ return;
+ if (m_localRoot->frameView()) {
dcheng 2017/01/12 11:32:08 Though I suppose this check is probably necessary
kenrb 2017/01/12 19:51:27 Agreed.
+ m_localRoot->frameView()->setViewportIntersectionFromParent(
+ viewportIntersection);
+ }
+}
+
void WebFrameWidgetImpl::handleMouseLeave(LocalFrame& mainFrame,
const WebMouseEvent& event) {
// FIXME: WebWidget doesn't have the method below.
« no previous file with comments | « third_party/WebKit/Source/web/WebFrameWidgetImpl.h ('k') | third_party/WebKit/public/web/WebFrameWidget.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698