Intersection Observer support for OOPIF

third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index 9ab3a0a81e75eaf26acc7f379859d0e9140d532b..eb63520b55256306945b16e67c44f8c63acb8c59 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -725,6 +725,17 @@ void WebFrameWidgetImpl::applyReplacementRange(const WebRange& range) {
   }
 }
 
+void WebFrameWidgetImpl::setRemoteViewportIntersection(
+    const WebRect& viewportIntersection) {
+  // Remote viewports are only applicable to local frames with remote ancestors.
+  if (!m_localRoot->parent() || !m_localRoot->parent()->isWebRemoteFrame())

[dcheng, 2017/01/05 07:10:19]

Are these DCHECKable conditions? It seems like we shouldn't be sending the IPC
to begin with if these conditions aren't true.

+    return;
+  if (m_localRoot->frameView()) {

[dcheng, 2017/01/05 07:10:19]

Why would it not have a frame view? IPC races?

[kenrb, 2017/01/09 19:31:20]

Yes, I don't know how to justify these as invariants in cases where an update is
happening concurrently with frame detachment or a swap, for this and the
preceding comment.

+    m_localRoot->frameView()->setViewportIntersectionFromParent(
+        viewportIntersection);
+  }
+}
+
 void WebFrameWidgetImpl::handleMouseLeave(LocalFrame& mainFrame,
                                           const WebMouseEvent& event) {
   // FIXME: WebWidget doesn't have the method below.