Intersection Observer support for OOPIF

third_party/WebKit/Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 29 matching lines @@
 #include "core/editing/RenderedPosition.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/events/ErrorEvent.h"
 #include "core/fetch/ResourceFetcher.h"
 #include "core/frame/BrowserControls.h"
 #include "core/frame/EventHandlerRegistry.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalFrame.h"
 #include "core/frame/Location.h"
 #include "core/frame/PageScaleConstraintsSet.h"
+#include "core/frame/RemoteFrame.h"
+#include "core/frame/RemoteFrameView.h"
 #include "core/frame/Settings.h"
 #include "core/frame/VisualViewport.h"
 #include "core/html/HTMLFrameElement.h"
 #include "core/html/HTMLPlugInElement.h"
 #include "core/html/HTMLTextFormControlElement.h"
 #include "core/html/parser/TextResourceDecoder.h"
 #include "core/input/EventHandler.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/inspector/InspectorTraceEvents.h"
 #include "core/layout/LayoutAnalyzer.h"
@@ skipping 4272 matching lines @@
     parent->m_needsUpdateViewportIntersectionInSubtree = true;
 }
 
 void FrameView::updateViewportIntersectionIfNeeded() {
   if (!m_needsUpdateViewportIntersection)
     return;
   m_needsUpdateViewportIntersection = false;
   m_viewportIntersectionValid = true;
   FrameView* parent = parentFrameView();
   if (!parent) {
+    // TODO(kenrb): For an OOPIF, we could use m_remoteViewportIntersection
+    // to compute m_viewportIntersection, but there needs to be a way to
+    // convert to the root frame's coordinate space when there are remote
+    // frame ancestors in the tree.
     HTMLFrameOwnerElement* element = frame().deprecatedLocalOwner();
     if (!element)
       frame().document()->maybeRecordLoadReason(WouldLoadOutOfProcess);
     // Having no layout object means the frame is not drawn.
     else if (!element->layoutObject())
       frame().document()->maybeRecordLoadReason(WouldLoadDisplayNone);
     m_viewportIntersection = frameRect();
     return;
   }
   ASSERT(!parent->m_needsUpdateViewportIntersection);
@@ skipping 57 matching lines @@
     m_frame->frameScheduler()->unthrottledTaskRunner()->postTask(
         BLINK_FROM_HERE,
         m_renderThrottlingObserverNotificationFactory->cancelAndCreate());
 
   if (!m_needsUpdateViewportIntersectionInSubtree)
     return;
   m_needsUpdateViewportIntersectionInSubtree = false;
 
   for (Frame* child = m_frame->tree().firstChild(); child;
        child = child->tree().nextSibling()) {
-    if (!child->isLocalFrame())
-      continue;
-    if (FrameView* view = toLocalFrame(child)->view())
+    if (child->isRemoteFrame() && toRemoteFrame(child)->view())
+      toRemoteFrame(child)->view()->updateRemoteViewportIntersection();
+    else if (FrameView* view = toLocalFrame(child)->view())
       view->updateViewportIntersectionsForSubtree(targetState);
   }
 }
 
+IntRect FrameView::viewportIntersection() {
+  if (m_viewportIntersectionValid)
+    return m_viewportIntersection;
+  return IntRect();
+}
+
 void FrameView::updateThrottlingStatus() {
   // Only offscreen frames can be throttled. Note that we disallow throttling
   // of 0x0 frames because some sites use them to drive UI logic.
   DCHECK(m_viewportIntersectionValid);
   m_hiddenForThrottling =
       m_viewportIntersection.isEmpty() && !frameRect().isEmpty();
 
   // We only throttle the rendering pipeline in cross-origin frames. This is
   // to avoid a situation where an ancestor frame directly depends on the
   // pipeline timing of a descendant and breaks as a result of throttling.
@@ skipping 103 matching lines @@
 int FrameView::initialViewportWidth() const {
   DCHECK(m_frame->isMainFrame());
   return m_initialViewportSize.width();
 }
 
 int FrameView::initialViewportHeight() const {
   DCHECK(m_frame->isMainFrame());
   return m_initialViewportSize.height();
 }
 
+void FrameView::setViewportIntersectionFromParent(
+    const IntRect& viewportIntersection) {
+  m_remoteViewportIntersection = viewportIntersection;
+  setNeedsUpdateViewportIntersection();
+  updateAllLifecyclePhases();

[kenrb, 2016/11/07 18:48:49]

Is this call okay? I was finding that the test was failing because lifecycle
phases didn't get updated after the remote ancestor frame scrolled, even though
we got the correct intersection update. Or is there an indirect way to trigger
that to happen?

[szager1, 2016/11/16 18:57:58]

This is not kosher.  I think you just want to:

if (m_remoteViewportIntersection != viewportIntersection)
  scheduleAnimation();

[kenrb, 2016/11/21 19:37:35]

Done.

+}
+
+IntRect FrameView::remoteViewportIntersection() {
+  IntRect intersection(m_remoteViewportIntersection);
+  intersection.move(scrollOffsetInt());
+  return intersection;
+}
+
 }  // namespace blink