Intersection Observer support for OOPIF

third_party/WebKit/Source/core/frame/RemoteFrameView.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/frame/RemoteFrameView.h"
 
 #include "core/frame/FrameView.h"
+#include "core/frame/LocalFrame.h"
 #include "core/frame/RemoteFrame.h"
+#include "core/frame/RemoteFrameClient.h"
 #include "core/html/HTMLFrameOwnerElement.h"
 #include "core/layout/api/LayoutPartItem.h"
+#include "platform/geometry/IntPoint.h"
 
 namespace blink {
 
 RemoteFrameView::RemoteFrameView(RemoteFrame* remoteFrame)
     : m_remoteFrame(remoteFrame) {
   ASSERT(remoteFrame);
 }
 
 RemoteFrameView::~RemoteFrameView() {}
 
 void RemoteFrameView::setParent(Widget* parent) {
   Widget::setParent(parent);
   frameRectsChanged();
 }
 
 RemoteFrameView* RemoteFrameView::create(RemoteFrame* remoteFrame) {
   RemoteFrameView* view = new RemoteFrameView(remoteFrame);
   view->show();
   return view;
 }
 
+void RemoteFrameView::updateRemoteViewportIntersection() {
+  if (!m_remoteFrame->tree().parent() ||
+      !m_remoteFrame->tree().parent()->isLocalFrame() ||
+      !m_remoteFrame->client())
+    return;
+
+  FrameView* parent = toLocalFrame(m_remoteFrame->tree().parent())->view();
+  if (!parent)
+    return;
+
+  // TODO(kenrb): I don't think this works with nested OOPIFs. We need to take
+  // the local frame root's rootOffset into account to get actual viewport pos.
+  IntRect viewportIntersection = parent->contentsToRootFrame(frameRect());

[szager1, 2016/10/24 16:54:52]

I don't think this is right, because parentsToRootFrame does not calculate
clipping up the layout tree.  For example:

<div style="overflow:scroll; width:100px; height:100px;">
  <iframe></iframe>
</div>

contentToRootFrame will not apply the overflow clip of the div.  Instead, use
frame()->ownerLayoutObject()->mapToVisualRectInAncestorSpace().

[kenrb, 2016/10/28 18:51:56]

Done.

+  IntPoint rootOffset(viewportIntersection.x(), viewportIntersection.y());
+
+  IntRect parentViewportIntersection = parent->viewportIntersection();
+  if (parentViewportIntersection.isEmpty()) {
+    m_remoteFrame->client()->updateRemoteViewportIntersection(
+        parentViewportIntersection, rootOffset);
+    return;
+  }
+
+  viewportIntersection.intersect(parentViewportIntersection);
+  if (viewportIntersection != m_lastViewportIntersection) {
+    m_remoteFrame->client()->updateRemoteViewportIntersection(
+        viewportIntersection, rootOffset);
+  }
+  m_lastViewportIntersection = viewportIntersection;
+}
+
 void RemoteFrameView::dispose() {
   HTMLFrameOwnerElement* ownerElement = m_remoteFrame->deprecatedLocalOwner();
   // ownerElement can be null during frame swaps, because the
   // RemoteFrameView is disconnected before detachment.
   if (ownerElement && ownerElement->ownedWidget() == this)
     ownerElement->setWidget(nullptr);
   Widget::dispose();
 }
 
 void RemoteFrameView::invalidateRect(const IntRect& rect) {
@@ skipping 19 matching lines @@
 }
 
 void RemoteFrameView::frameRectsChanged() {
   // Update the rect to reflect the position of the frame relative to the
   // containing local frame root. The position of the local root within
   // any remote frames, if any, is accounted for by the embedder.
   IntRect newRect = frameRect();
   if (parent() && parent()->isFrameView())
     newRect = parent()->convertToRootFrame(
         toFrameView(parent())->contentsToFrame(newRect));
-  m_remoteFrame->frameRectsChanged(newRect);
+  m_remoteFrame->client()->frameRectsChanged(newRect);
+
+  updateRemoteViewportIntersection();
 }
 
 void RemoteFrameView::hide() {
   setSelfVisible(false);
 
   Widget::hide();
 
-  m_remoteFrame->visibilityChanged(false);
+  if (m_remoteFrame->client())
+    m_remoteFrame->client()->visibilityChanged(false);
 }
 
 void RemoteFrameView::show() {
   setSelfVisible(true);
 
   Widget::show();
 
-  m_remoteFrame->visibilityChanged(true);
+  if (m_remoteFrame->client())
+    m_remoteFrame->client()->visibilityChanged(true);
 }
 
 void RemoteFrameView::setParentVisible(bool visible) {
   if (isParentVisible() == visible)
     return;
 
   Widget::setParentVisible(visible);
   if (!isSelfVisible())
     return;
 
-  m_remoteFrame->visibilityChanged(isVisible());
+  if (m_remoteFrame->client())
+    m_remoteFrame->client()->visibilityChanged(isVisible());
 }
 
 DEFINE_TRACE(RemoteFrameView) {
   visitor->trace(m_remoteFrame);
   Widget::trace(visitor);
 }
 
 }  // namespace blink