Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1711)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2431473002: Change single-display screens to use ScreenBase and DisplayList. (Closed)
Patch Set: renderer test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 3cabe3e2db1cda955bb6be3903c1d8550f6843b6..424aab2eff803f4efaaf1b82427aa48755c2854f 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -1514,7 +1514,11 @@ TEST_F(RenderWidgetHostViewAuraTest, PhysicalBackingSizeWithScale) {
aura_test_helper_->test_screen()->SetDeviceScaleFactor(2.0f);
EXPECT_EQ("200x200", view_->GetPhysicalBackingSize().ToString());
// Extra ScreenInfoChanged message for |parent_view_|.
- EXPECT_EQ(0u, sink_->message_count());
+ // Changing the device scale factor triggers the
+ // RenderWidgetHostViewAura::OnDisplayMetricsChanged() observer callback,
+ // which sends a ViewMsg_Resize::ID message to the renderer.
+ EXPECT_EQ(1u, sink_->message_count());
+ EXPECT_EQ(ViewMsg_Resize::ID, sink_->GetMessageAt(0)->type());
auto view_delegate = static_cast<MockRenderWidgetHostDelegate*>(
static_cast<RenderWidgetHostImpl*>(view_->GetRenderWidgetHost())
->delegate());
@@ -1525,7 +1529,8 @@ TEST_F(RenderWidgetHostViewAuraTest, PhysicalBackingSizeWithScale) {
aura_test_helper_->test_screen()->SetDeviceScaleFactor(1.0f);
// Extra ScreenInfoChanged message for |parent_view_|.
- EXPECT_EQ(0u, sink_->message_count());
+ EXPECT_EQ(1u, sink_->message_count());
+ EXPECT_EQ(ViewMsg_Resize::ID, sink_->GetMessageAt(0)->type());
EXPECT_EQ(1.0f, view_delegate->get_last_device_scale_factor());
EXPECT_EQ("100x100", view_->GetPhysicalBackingSize().ToString());
}
« no previous file with comments | « content/browser/media/capture/web_contents_video_capture_device_unittest.cc ('k') | extensions/shell/browser/shell_screen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698