Use dart:html prefixes (e.g. webkitAudioNode) on other browsers

Use dart:html prefixes (e.g. webkitAudioNode) on other browsers

BUG=
R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/47150f50d574242f8c9a9f6cbd3d3af2e2f5e02b

[Alan Knight, 2016-10-17 22:52:26]

alanknight@google.com changed reviewers:
+ vsm@google.com

[vsm, 2016-10-17 23:08:29]

https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1604:
'dart.setExtensionBaseClass(#, #);', [className, newBaseClass]));
Hmm - I'm a little surprised this works.  Looking at the code for
setExtensionBaseClass, it looks like a second call will undo the first.

Have you tried internal apps under Chrome to make sure they still work?  Our
test coverage is probably lacking here.

[vsm, 2016-10-17 23:17:59]

https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):

https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
pkg/dev_compiler/lib/src/compiler/code_generator.dart:1604:
'dart.setExtensionBaseClass(#, #);', [className, newBaseClass]));
On 2016/10/17 23:08:29, vsm wrote:
> Hmm - I'm a little surprised this works.  Looking at the code for
> setExtensionBaseClass, it looks like a second call will undo the first.
> 
> Have you tried internal apps under Chrome to make sure they still work?  Our
> test coverage is probably lacking here.

Ahh, looks like combination of type parameters and multiple peers never comes
up.  :-)  I see no new calls in the generated code from this.

Do we expect only one peer to exist (i.e., not be undefined)?  If so, maybe we
just need a check in setExtensionBaseClass?  If more - is the code supposed to
prefer one?

[Alan Knight, 2016-10-18 00:18:42]

On 2016/10/17 23:17:59, vsm wrote:
>
https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
> File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right):
> 
>
https://codereview.chromium.org/2431443002/diff/20001/pkg/dev_compiler/lib/sr...
> pkg/dev_compiler/lib/src/compiler/code_generator.dart:1604:
> 'dart.setExtensionBaseClass(#, #);', [className, newBaseClass]));
> On 2016/10/17 23:08:29, vsm wrote:
> > Hmm - I'm a little surprised this works.  Looking at the code for
> > setExtensionBaseClass, it looks like a second call will undo the first.
> > 
> > Have you tried internal apps under Chrome to make sure they still work?  Our
> > test coverage is probably lacking here.
> 
> Ahh, looks like combination of type parameters and multiple peers never comes
> up.  :-)  I see no new calls in the generated code from this.
> 
> Do we expect only one peer to exist (i.e., not be undefined)?  If so, maybe we
> just need a check in setExtensionBaseClass?  If more - is the code supposed to
> prefer one?

DRX seems to come up with its initial screen the same as it did without this
change. I'm not sure how else to exercise it.

Yes, we expect only one peer to exist. If there's more than one we might prefer
the unprefixed, but really I don't think it matters. I'll add a check in
setExtensionBaseClass.

[Alan Knight, 2016-10-19 22:20:23]

PTAL.  Added the check in setExtensionBaseClass and verified the test app
doesn't break.

[vsm, 2016-10-19 22:49:47]

lgtm

https://codereview.chromium.org/2431443002/diff/40001/pkg/dev_compiler/tool/i...
File pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart (right):

https://codereview.chromium.org/2431443002/diff/40001/pkg/dev_compiler/tool/i...
pkg/dev_compiler/tool/input_sdk/private/ddc_runtime/classes.dart:509: }
Nit: bad indent

[Alan Knight, 2016-10-19 23:43:49]

Description was changed from

==========
Use dart:html prefixes (e.g. webkitAudioNode) on other browsers

BUG=
==========

to

==========
Use dart:html prefixes (e.g. webkitAudioNode) on other browsers

BUG=
R=vsm@google.com

Committed:
https://github.com/dart-lang/dev_compiler/commit/47150f50d574242f8c9a9f6cbd3d...
==========

[Alan Knight, 2016-10-19 23:43:50]

Committed patchset #4 (id:60001) manually as
47150f50d574242f8c9a9f6cbd3d3af2e2f5e02b (presubmit successful).