Log an error in release builds when NOTREACHED is hit

Log an error in release builds when NOTREACHED is hit in ChromiumOS builds.  This data can be collected on ChromiumOS when the user consents to it; this should help us collect more data about what shouldn't be happening in prod that happens anyways.

BUG=288014
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225383

[Zachary Kuznia, 2013-09-23 20:01:47]

Hi Nico,

Could you take a look at this?

Thanks,
-Zach

[Nico, 2013-09-23 20:06:12]

What's this good for? We don't want to spam stdout for users. If we want to
catch NOTREACHED()s getting hit in practice, this should CHECK(false), but
that'd be a big semantic change.

Oh, judging from the bug that's for CrOS where you apparently look at log
output? Hm. Maybe this should be cros-only?

Adding a __FUNCTION__ string constant for every function to every function that
calls NOTREACHED() will increase binary size by some amount. Have you measured
by how much?

[Zachary Kuznia, 2013-09-23 21:45:40]

On 2013/09/23 20:06:12, Nico wrote:
> What's this good for? We don't want to spam stdout for users. If we want to
> catch NOTREACHED()s getting hit in practice, this should CHECK(false), but
> that'd be a big semantic change.
> 
> Oh, judging from the bug that's for CrOS where you apparently look at log
> output? Hm. Maybe this should be cros-only?
> 
> Adding a __FUNCTION__ string constant for every function to every function
that
> calls NOTREACHED() will increase binary size by some amount. Have you measured
> by how much?

Changed to be ChromeOS only.

This increases the binary size on the device by 0.5%, to 172.8MB from 172.1MB

[Nico, 2013-09-24 00:50:51]

lgtm

Please change the CL description to make clear that this is cros-only, and that
this makes sense on cros as the logs can be collected there somehow (given
consent etc)

[commit-bot: I haz the power, 2013-09-24 21:27:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/24313004/5001

[commit-bot: I haz the power, 2013-09-24 23:22:27]

Retried try job too often on linux_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-09-24 23:29:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/24313004/5001

[commit-bot: I haz the power, 2013-09-25 01:32:09]

Retried try job too often on linux_rel for step(s) remoting_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-09-25 20:06:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/24313004/5001

[commit-bot: I haz the power, 2013-09-25 21:40:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zork@chromium.org/24313004/5001

[commit-bot: I haz the power, 2013-09-26 07:55:22]

Change committed as 225383