Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2431233003: [turbofan] Also remove minus zero check for rhs of CheckedInt32Add. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Also remove minus zero check for rhs of CheckedInt32Add. Similar to http://crrev.com/2410883003 we don't need to do a minus zero check for the right hand side of CheckedInt32Add, because we already know that the left hand side cannot be minus zero, and the only way that addition can yield -0 is (-0) + (-0). R=jarin@chromium.org Committed: https://crrev.com/8b94aee525b4770d69875bc4f03742d46d551a29 Cr-Commit-Position: refs/heads/master@{#40421}

Patch Set 1 #

Patch Set 2 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler/simplified-lowering.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-19 07:23:22 UTC) #1
Jarin
lgtm
4 years, 2 months ago (2016-10-19 07:25:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2431233003/20001
4 years, 2 months ago (2016-10-19 07:26:30 UTC) #9
Benedikt Meurer
4 years, 2 months ago (2016-10-19 08:28:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8b94aee525b4770d69875bc4f03742d46d551a29 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698