Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: media/gpu/vt_video_encode_accelerator_mac.cc

Issue 2431223011: Limit VTVideoEncodeAccelerator keyframe output (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/gpu/vt_video_encode_accelerator_mac.cc
diff --git a/media/gpu/vt_video_encode_accelerator_mac.cc b/media/gpu/vt_video_encode_accelerator_mac.cc
index 38429484b38d2528b9318fcd30a16be908876bb7..4a3b74e32be01505b2f5ba0c89bdfd02a8b1ec3b 100644
--- a/media/gpu/vt_video_encode_accelerator_mac.cc
+++ b/media/gpu/vt_video_encode_accelerator_mac.cc
@@ -560,6 +560,14 @@ bool VTVideoEncodeAccelerator::ConfigureCompressionSession() {
rv &= session_property_setter.Set(
videotoolbox_glue_->kVTCompressionPropertyKey_AllowFrameReordering(),
false);
+ // Limit keyframe output to 4 minutes, see crbug.com/658429.
+ rv &= session_property_setter.Set(
+ videotoolbox_glue_->kVTCompressionPropertyKey_MaxKeyFrameInterval(),
+ 7200);
+ rv &= session_property_setter.Set(
+ videotoolbox_glue_
+ ->kVTCompressionPropertyKey_MaxKeyFrameIntervalDuration(),
+ 240);
DLOG_IF(ERROR, !rv) << " Setting session property failed.";
return rv;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698