Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431223011:
Limit VTVideoEncodeAccelerator keyframe output (Closed)
|
Created:
4 years, 2 months ago by emircan Modified:
4 years, 1 month ago Reviewers:
DaleCurtis CC:
chromium-reviews, feature-media-reviews_chromium.org, mac-reviews_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLimit VTVideoEncodeAccelerator keyframe output
On Macbook Air 2013, letting this be default results in a keyframe every ~5
seconds. This is too often for some applications. This CL changes this limit
so that max keyframe interval is 4 minutes.
BUG=658429
TEST=AppRTC loopback on Mac.
Committed: https://crrev.com/3d279e0818e6b27c0374ee8782748c6e3859785f
Cr-Commit-Position: refs/heads/master@{#427143}
Patch Set 1 #
Messages
Total messages: 18 (11 generated)
The CQ bit was checked by emircan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== limit to 4 mins BUG= ========== to ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL limits changes this so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ==========
emircan@chromium.org changed reviewers: + dalecurtis@chromium.org
Quick change. PTAL.
Description was changed from ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL limits changes this so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ========== to ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL limits changes this so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ==========
Description was changed from ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL limits changes this so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ========== to ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Do you really want a fixed value here? Won't any corruption in transit take forever to recover if you do this?
lgtm
On 2016/10/24 18:48:58, DaleCurtis wrote: > Do you really want a fixed value here? Won't any corruption in transit take > forever to recover if you do this? For those cases, there is |force_keyframe| param in encode which sets the current frame as keyframe. This fixed value sets the max interval when |force_keyframe_| is not used and I got 4 mins from WebRTC standalone implementation.
The CQ bit was checked by emircan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ========== to ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. ========== to ========== Limit VTVideoEncodeAccelerator keyframe output On Macbook Air 2013, letting this be default results in a keyframe every ~5 seconds. This is too often for some applications. This CL changes this limit so that max keyframe interval is 4 minutes. BUG=658429 TEST=AppRTC loopback on Mac. Committed: https://crrev.com/3d279e0818e6b27c0374ee8782748c6e3859785f Cr-Commit-Position: refs/heads/master@{#427143} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3d279e0818e6b27c0374ee8782748c6e3859785f Cr-Commit-Position: refs/heads/master@{#427143} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
