Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: src/compiler/js-builtin-reducer.cc

Issue 2431223010: [builtins] fix load of surrogate pair for BE platform (Closed)
Patch Set: addressed comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-builtin-reducer.cc
diff --git a/src/compiler/js-builtin-reducer.cc b/src/compiler/js-builtin-reducer.cc
index 103bb09947103a36012daf7578da944e4a03e799..edf63ba262d55b2afb7dbd2b42886ba83b5b38d2 100644
--- a/src/compiler/js-builtin-reducer.cc
+++ b/src/compiler/js-builtin-reducer.cc
@@ -1141,9 +1141,16 @@ Reduction JSBuiltinReducer::ReduceStringIteratorNext(Node* node) {
{
vtrue3 = graph()->NewNode(
simplified()->NumberBitwiseOr(),
+// Need to swap the order for big-endian platforms
+#if V8_TARGET_BIG_ENDIAN
+ graph()->NewNode(simplified()->NumberShiftLeft(), lead,
+ jsgraph()->Int32Constant(16)),
+ trail);
+#else
graph()->NewNode(simplified()->NumberShiftLeft(), trail,
jsgraph()->Int32Constant(16)),
lead);
+#endif
}
Node* if_false3 = graph()->NewNode(common()->IfFalse(), branch3);
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698