Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: test/mjsunit/element-accessor.js

Issue 2431223005: Implement DefineOwnProperty for TypedArrays (Closed)
Patch Set: formatting fixes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/element-accessor.js
diff --git a/test/mjsunit/element-accessor.js b/test/mjsunit/element-accessor.js
index 5fba359c2a769cd5b46598bacc385c519ffa7762..94acc5c6c3533e2349c0be4f22632d079fb45391 100644
--- a/test/mjsunit/element-accessor.js
+++ b/test/mjsunit/element-accessor.js
@@ -29,9 +29,15 @@
})();
(function () {
- var o = new Int32Array();
- Object.defineProperty(o, "0", {get: function(){}});
- assertEquals(undefined, Object.getOwnPropertyDescriptor(o, "0"));
+ var o = new Int32Array(1);
+ assertThrows(
+ () => Object.defineProperty(o, '0', {get: function() {}}), TypeError);
Dan Ehrenberg 2016/11/28 23:01:40 Looks like this case started to throw when it prev
caitp 2016/11/28 23:10:10 Defining accessors on typed arrays used to fail si
Dan Ehrenberg 2016/11/28 23:13:13 OK, if we're not the first to ship this fix, I'm f
+ assertEquals({
+ value: 0,
+ writable: true,
+ enumerable: true,
+ configurable: false
+ }, Object.getOwnPropertyDescriptor(o, "0"));
})();
(function() {
« no previous file with comments | « src/objects.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698