Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: test/mjsunit/element-accessor.js

Issue 2431223005: Implement DefineOwnProperty for TypedArrays (Closed)
Patch Set: Refactor CanonicalNumericIndexString and fix tests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/element-accessor.js
diff --git a/test/mjsunit/element-accessor.js b/test/mjsunit/element-accessor.js
index 5fba359c2a769cd5b46598bacc385c519ffa7762..e086a075d4b166cfc7e1cd270abe30c5573fd680 100644
--- a/test/mjsunit/element-accessor.js
+++ b/test/mjsunit/element-accessor.js
@@ -29,9 +29,14 @@
})();
(function () {
- var o = new Int32Array();
- Object.defineProperty(o, "0", {get: function(){}});
- assertEquals(undefined, Object.getOwnPropertyDescriptor(o, "0"));
caitp 2016/11/17 15:24:42 this old test was wrong per spec, does it still pa
Henrique Ferreiro 2016/11/18 09:27:07 IntegerIndexedElementGet: Step 8. If index < 0 or
caitp 2016/11/18 14:47:51 No, Object.defineProperty should throw here, becau
+ var o = new Int32Array(1);
+ assertThrows('Object.defineProperty(o, "0", {get: function(){}})');
Dan Ehrenberg 2016/11/18 16:03:52 Nit: For new tests, pass two arguments: the code t
+ assertEquals({
+ value: 0,
+ writable: true,
+ enumerable: true,
+ configurable: false
+ }, Object.getOwnPropertyDescriptor(o, "0"));
})();
(function() {
« src/objects.cc ('K') | « src/objects.cc ('k') | test/test262/test262.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698