test/mjsunit/element-accessor.js - Issue 2431223005: Implement DefineOwnProperty for TypedArrays

Unified Diff: test/mjsunit/element-accessor.js

Issue 2431223005: Implement DefineOwnProperty for TypedArrays (Closed)

Patch Set: Fix tests and a type conversion mistake Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/mjsunit/element-accessor.js

diff --git a/test/mjsunit/element-accessor.js b/test/mjsunit/element-accessor.js

index 5fba359c2a769cd5b46598bacc385c519ffa7762..cf2372abc9a67b6b247d900dba8ac6659ad642da 100644

--- a/test/mjsunit/element-accessor.js

+++ b/test/mjsunit/element-accessor.js

@@ -29,8 +29,8 @@

})();

(function () {

- var o = new Int32Array();

- Object.defineProperty(o, "0", {get: function(){}});

+ var o = new Int32Array(1);

Henrique Ferreiro 2016/11/15 13:07:55 I assumed that we are checking particularly for ac

caitp 2016/11/15 15:10:57 Why not test both?

Henrique Ferreiro 2016/11/15 22:03:13 Well, this test is called element-accessor.js, the

+ assertThrows('Object.defineProperty(o, "0", {get: function(){}})');

assertEquals(undefined, Object.getOwnPropertyDescriptor(o, "0"));

caitp 2016/11/15 15:10:57 isn't this assertion going to fail with this chang

Henrique Ferreiro 2016/11/15 22:03:13 It returns 'undefined', as it used to do. I don't

caitp 2016/11/15 22:13:50 It shouldn't return undefined, because it _should_

caitp 2016/11/15 22:17:01 in detail, the typed array is created via https://

})();