Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2360)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 2431223004: android: Don't keep GSA alive if it supports account change broadcasts. (Closed)
Patch Set: Address comments. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 82b0d37d7c9e25e25badfb4c090e613bfeec7918..d635c418124071354fc96ec5484f6a542e2d83bf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -77,7 +77,7 @@ import org.chromium.chrome.browser.download.DownloadManagerService;
import org.chromium.chrome.browser.download.DownloadUtils;
import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
import org.chromium.chrome.browser.gsa.ContextReporter;
-import org.chromium.chrome.browser.gsa.GSAServiceClient;
+import org.chromium.chrome.browser.gsa.GSAAccountChangeListener;
import org.chromium.chrome.browser.gsa.GSAState;
import org.chromium.chrome.browser.help.HelpAndFeedback;
import org.chromium.chrome.browser.infobar.InfoBarContainer;
@@ -196,7 +196,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
private TabContentManager mTabContentManager;
private UmaSessionStats mUmaSessionStats;
private ContextReporter mContextReporter;
- protected GSAServiceClient mGSAServiceClient;
private boolean mPartnerBrowserRefreshNeeded;
@@ -639,8 +638,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
ChromeActivitySessionTracker.getInstance().onStartWithNative();
if (GSAState.getInstance(this).isGsaAvailable()) {
- mGSAServiceClient = new GSAServiceClient(this);
- mGSAServiceClient.connect();
+ GSAAccountChangeListener.getInstance().connect();
createContextReporterIfNeeded();
} else {
ContextReporter.reportStatus(ContextReporter.STATUS_GSA_NOT_AVAILABLE);
@@ -742,9 +740,9 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
Tab tab = getActivityTab();
if (tab != null && !hasWindowFocus()) tab.onActivityHidden();
if (mAppMenuHandler != null) mAppMenuHandler.hideAppMenu();
- if (mGSAServiceClient != null) {
- mGSAServiceClient.disconnect();
- mGSAServiceClient = null;
+
+ if (GSAState.getInstance(this).isGsaAvailable()) {
+ GSAAccountChangeListener.getInstance().disconnect();
if (mSyncStateChangedListener != null) {
ProfileSyncService syncService = ProfileSyncService.get();
if (syncService != null) {

Powered by Google App Engine
This is Rietveld 408576698