[DevTools]: Require explicit connection

third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

 /*
  * Copyright 2014 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 /**
  * @constructor
  * @extends {WebInspector.Object}
  */
@@ skipping 167 matching lines @@
     {
         delete targetObserver[this._observerCapabiliesMaskSymbol];
         this._observers.remove(targetObserver);
     },
 
     /**
      * @param {string} name
      * @param {number} capabilitiesMask
      * @param {!InspectorBackendClass.Connection.Factory} connectionFactory
      * @param {?WebInspector.Target} parentTarget
+     * @param {boolean=} createOnly
      * @return {!WebInspector.Target}
      */
-    createTarget: function(name, capabilitiesMask, connectionFactory, parentTarget)
+    createTarget: function(name, capabilitiesMask, connectionFactory, parentTarget, createOnly)
     {
         var target = new WebInspector.Target(this, name, capabilitiesMask, connectionFactory, parentTarget);
 
         var logAgent = target.hasLogCapability() ? target.logAgent() : null;
 
         /** @type {!WebInspector.ConsoleModel} */
         target.consoleModel = new WebInspector.ConsoleModel(target, logAgent);
 
         var networkManager = null;
         var resourceTreeModel = null;
@@ skipping 22 matching lines @@
         target.cpuProfilerModel = new WebInspector.CPUProfilerModel(target);
         /** @type {!WebInspector.HeapProfilerModel} */
         target.heapProfilerModel = new WebInspector.HeapProfilerModel(target);
 
         target.tracingManager = new WebInspector.TracingManager(target);
 
         if (target.hasBrowserCapability()) {
             target.subTargetsManager = new WebInspector.SubTargetsManager(target);
             target.serviceWorkerManager = new WebInspector.ServiceWorkerManager(target, target.subTargetsManager);
         }
-
-        this.addTarget(target);
+        if (!createOnly)

[dgozman, 2016/10/26 22:14:06]

Let's avoid this boolean at all costs.

+            this.addTarget(target);
         return target;
     },
 
     /**
      * @param {function(function(string)):!Promise<!InspectorBackendClass.Connection>} interceptor
      */
     setMainConnectionInterceptor: function(interceptor)
     {
         this._mainConnectionInterceptor = interceptor;
     },
@@ skipping 156 matching lines @@
     /**
      * @param {!WebInspector.Target} target
      */
     targetRemoved: function(target) { },
 };
 
 /**
  * @type {!WebInspector.TargetManager}
  */
 WebInspector.targetManager = new WebInspector.TargetManager();