Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 24312009: Properly forward queued touch events (Closed)

Created:
7 years, 3 months ago by jdduke (slow)
Modified:
7 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Properly forward queued touch events If a touch-event is added to an empty TouchEventQueue and should not be forwarded to the renderer, it is ack'ed to the client immediately. However, this ack may trigger follow-up events synchronously, which would be queued but never forwarded to the renderer. Properly forward the follow-up events when the first event reaches an empty queue but was never forwarded. BUG=230735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224936

Patch Set 1 #

Patch Set 2 : Unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -7 lines) Patch
M content/browser/renderer_host/input/immediate_input_router_unittest.cc View 1 1 chunk +85 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/mock_input_ack_handler.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mock_input_ack_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/touch_event_queue.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
jdduke (slow)
PTAL for a sanity check. I'll add some tests that hit this corner case, thanks.
7 years, 3 months ago (2013-09-23 19:50:38 UTC) #1
jdduke (slow)
@sadrul: PTAL. Yufeng brough up a corner case that neither platform currently hits, but that ...
7 years, 3 months ago (2013-09-23 20:50:53 UTC) #2
Yufeng Shen (Slow to review)
On 2013/09/23 19:50:38, jdduke wrote: > PTAL for a sanity check. I'll add some tests ...
7 years, 3 months ago (2013-09-23 21:13:28 UTC) #3
sadrul
Yep. This seems reasonable to me.
7 years, 3 months ago (2013-09-23 22:37:40 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 3 months ago (2013-09-23 22:47:25 UTC) #5
sadrul
LGTM
7 years, 3 months ago (2013-09-23 22:48:40 UTC) #6
jdduke (slow)
aelias@ for owners. Thanks!
7 years, 3 months ago (2013-09-23 22:49:35 UTC) #7
jdduke (slow)
Oops, aelias@ please disregard review (unless you want to :)... for whatever reason I thought ...
7 years, 3 months ago (2013-09-23 22:53:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/24312009/4001
7 years, 3 months ago (2013-09-23 22:58:47 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=201569
7 years, 3 months ago (2013-09-24 03:48:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/24312009/4001
7 years, 3 months ago (2013-09-24 04:27:57 UTC) #11
commit-bot: I haz the power
7 years, 3 months ago (2013-09-24 07:10:44 UTC) #12
Message was sent while issue was closed.
Change committed as 224936

Powered by Google App Engine
This is Rietveld 408576698