Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2431133003:
Add more JSArray verification for --verify-heap (Closed)
|
Created:
4 years, 2 months ago by Camillo Bruni Modified:
4 years, 1 month ago Reviewers:
Igor Sheludko CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionAdd more JSArray verification for --verify-heap
BUG=
Committed: https://crrev.com/0909e5cccb871c41161882204bc0f64d95d35299
Cr-Commit-Position: refs/heads/master@{#40969}
Patch Set 1 #Patch Set 2 : fixing unsigned compare #Patch Set 3 : fix comment #Patch Set 4 : fixing signed compare #Patch Set 5 : maybe I get the casts right this time #Messages
Total messages: 24 (19 generated)
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
cbruni@chromium.org changed reviewers: + ishell@chromium.org
PTAL some more checks will never hurt...
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/15845)
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
The CQ bit was checked by cbruni@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Add more JSArray verification for --verify-heap BUG= ========== to ========== Add more JSArray verification for --verify-heap BUG= Committed: https://crrev.com/0909e5cccb871c41161882204bc0f64d95d35299 Cr-Commit-Position: refs/heads/master@{#40969} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/0909e5cccb871c41161882204bc0f64d95d35299 Cr-Commit-Position: refs/heads/master@{#40969} |
