Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2431103003: Don't gvn HForeignCode without source text (Closed)

Created:
4 years, 2 months ago by sra1
Modified:
4 years, 2 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't gvn HForeignCode without source text There are a few synthetic templates that are generated from trees instead of source text. I don't think any are marked for GVN, but this is a hazard so best fix it. TBR=sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3b5c1541386a71ea1c3715298710a82dab1ce4d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/compiler/lib/src/ssa/nodes.dart View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
4 years, 2 months ago (2016-10-19 21:35:35 UTC) #2
sra1
Committed patchset #1 (id:1) manually as 3b5c1541386a71ea1c3715298710a82dab1ce4d9 (presubmit successful).
4 years, 2 months ago (2016-10-19 21:47:06 UTC) #4
Siggi Cherem (dart-lang)
4 years, 2 months ago (2016-10-19 22:11:35 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698