Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2431093005: Browser tests for the quick_unlock settings pages. (Closed)

Created:
4 years, 2 months ago by jdufault
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Browser tests for the quick_unlock settings pages. BUG=627928 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2157673002 Cr-Commit-Position: refs/heads/master@{#425386} (cherry picked from commit 12d223ad3993032f0b5339187d1e6beaa86002af) Committed: https://chromium.googlesource.com/chromium/src/+/eb18f6521660743b0fb77438650897fa8bc8a5e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -206 lines) Patch
M chrome/browser/resources/options_resources.grd View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/icons.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_screen.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/people_page/lock_state_behavior.js View 3 chunks +13 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/people_page/password_prompt_dialog.js View 6 chunks +45 lines, -24 lines 0 comments Download
D chrome/browser/resources/settings/people_page/quick_unlock_choose_method.js View 1 chunk +0 lines, -174 lines 0 comments Download
M chrome/browser/resources/settings/people_page/setup_pin_dialog.html View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/people_page/setup_pin_dialog.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/test/data/webui/settings/fake_quick_unlock_private.js View 1 chunk +64 lines, -0 lines 0 comments Download
A chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js View 1 chunk +456 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jdufault
4 years, 2 months ago (2016-10-20 18:36:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb18f6521660743b0fb77438650897fa8bc8a5e2.

Powered by Google App Engine
This is Rietveld 408576698