Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 243109: Merge 28102 - DevTools: fix 'devtools.html' generation on Linux.... (Closed)

Created:
11 years, 2 months ago by laforge
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Merge 28102 - DevTools: fix 'devtools.html' generation on Linux. BUG=23858 TEST=interactive_ui_tests Review URL: http://codereview.chromium.org/256076 TBR=mnaganov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28108

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
MM webkit/webkit.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
11 years, 2 months ago (2009-10-06 15:14:17 UTC) #1
mnaganov (inactive)
11 years, 2 months ago (2009-10-06 16:52:01 UTC) #2
Thank you very much, Anthony!

On Tue, Oct 6, 2009 at 19:14,  <laforge@chromium.org> wrote:
> Reviewers: Michail Naganov,
>
> Description:
> Merge 28102 - DevTools: fix 'devtools.html' generation on Linux.
>
> BUG=3D23858
> TEST=3Dinteractive_ui_tests
>
> Review URL: http://codereview.chromium.org/256076
>
> TBR=3Dmnaganov@chromium.org
>
> Please review this at http://codereview.chromium.org/243109
>
> SVN Base: svn://chrome-svn/chrome/branches/221/src/
>
> Affected files:
> =A0MM =A0 =A0webkit/webkit.gyp
>
>
> Index: webkit/webkit.gyp
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- webkit/webkit.gyp =A0 (revision 28107)
> +++ webkit/webkit.gyp =A0 (working copy)
> @@ -749,6 +749,9 @@
> =A0 =A0 =A0 'target_name': 'devtools_html',
> =A0 =A0 =A0 'type': 'none',
> =A0 =A0 =A0 'msvs_guid': '9BE5D4D5-E800-44F9-B6C0-27DF15A9D817',
> + =A0 =A0 =A0'sources': [
> + =A0 =A0 =A0 =A0'<(PRODUCT_DIR)/resources/inspector/devtools.html',
> + =A0 =A0 =A0],
> =A0 =A0 =A0 'actions': [
> =A0 =A0 =A0 =A0 {
> =A0 =A0 =A0 =A0 =A0 'action_name': 'devtools_html',
>
> Property changes on: webkit\webkit.gyp
> ___________________________________________________________________
> Added: svn:mergeinfo
> =A0 Merged
> /branches/chrome_webkit_merge_branch/src/webkit/webkit.gyp:r3734-4217,460=
6-5108,5177-5263
> =A0 Merged /trunk/src/webkit/webkit.gyp:r28102
>
>
>
>

Powered by Google App Engine
This is Rietveld 408576698