Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 243103008: Add DevToolsAgent::{enable,disable}Tracing (Closed)

Created:
6 years, 8 months ago by caseq
Modified:
6 years, 8 months ago
Reviewers:
pfeldman, yurys, loislo
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

Add DevToolsAgent::{enable,disable}Tracing This adds support for synchronously enabling/disabling tracing in devtools agent, so we can support tracing-based timeline enabled synchronously from the inspected renderer. BUG=361045 R=pfeldman@chromium.org, yurys@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266146

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/renderer/devtools/devtools_agent.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/devtools/devtools_agent.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
caseq
6 years, 8 months ago (2014-04-21 16:52:14 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/243103008/diff/1/content/renderer/devtools/devtools_agent.cc File content/renderer/devtools/devtools_agent.cc (right): https://codereview.chromium.org/243103008/diff/1/content/renderer/devtools/devtools_agent.cc#newcode168 content/renderer/devtools/devtools_agent.cc:168: TraceLog::RECORD_UNTIL_FULL); nit: do you want to pass this ...
6 years, 8 months ago (2014-04-21 17:50:52 UTC) #2
yurys
I'd rather we handled this in TracingAgent in the renderer: 1) Tracing.start is first handled ...
6 years, 8 months ago (2014-04-22 07:44:28 UTC) #3
pfeldman
I like yurys's plan.
6 years, 8 months ago (2014-04-22 07:48:08 UTC) #4
caseq
So what do we do with console.startTimeline()?
6 years, 8 months ago (2014-04-22 11:06:03 UTC) #5
yurys
lgtm
6 years, 8 months ago (2014-04-22 11:47:39 UTC) #6
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-24 06:22:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/243103008/1
6 years, 8 months ago (2014-04-24 06:22:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 08:27:35 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 08:27:35 UTC) #10
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-24 13:15:51 UTC) #11
caseq
The CQ bit was unchecked by caseq@chromium.org
6 years, 8 months ago (2014-04-24 13:33:38 UTC) #12
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-24 13:33:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/243103008/20001
6 years, 8 months ago (2014-04-24 13:34:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 15:54:12 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_rel
6 years, 8 months ago (2014-04-24 15:54:13 UTC) #16
caseq
The CQ bit was checked by caseq@chromium.org
6 years, 8 months ago (2014-04-24 17:01:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/caseq@chromium.org/243103008/20001
6 years, 8 months ago (2014-04-24 17:02:18 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 21:07:03 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-24 21:07:04 UTC) #20
caseq
6 years, 8 months ago (2014-04-25 07:20:18 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 manually as r266146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698