Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: chrome/browser/ui/location_bar/location_bar.cc

Issue 2430923010: Add a feature flag for the security verbose (Closed)
Patch Set: Added section to fieldtrial_testing_config.json Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/location_bar/location_bar.h" 5 #include "chrome/browser/ui/location_bar/location_bar.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h" 8 #include "chrome/common/extensions/manifest_handlers/ui_overrides_handler.h"
9 #include "extensions/browser/extension_registry.h" 9 #include "extensions/browser/extension_registry.h"
10 #include "extensions/common/extension_set.h" 10 #include "extensions/common/extension_set.h"
11 #include "extensions/common/feature_switch.h" 11 #include "extensions/common/feature_switch.h"
12 #include "extensions/common/permissions/permissions_data.h" 12 #include "extensions/common/permissions/permissions_data.h"
13 13
14 const char LocationBar::kSecurityChipFeatureVisibilityParam[] = "visibility";
15
Peter Kasting 2016/10/24 21:08:16 Nit: No blank line
spqchan 2016/10/24 22:44:56 Done.
16 const char LocationBar::kSecurityChipFeatureAnimationParam[] = "animation";
14 17
15 LocationBar::LocationBar(Profile* profile) : profile_(profile) { 18 LocationBar::LocationBar(Profile* profile) : profile_(profile) {
16 } 19 }
17 20
18 LocationBar::~LocationBar() { 21 LocationBar::~LocationBar() {
19 } 22 }
20 23
21 bool LocationBar::IsBookmarkStarHiddenByExtension() const { 24 bool LocationBar::IsBookmarkStarHiddenByExtension() const {
22 const extensions::ExtensionSet& extension_set = 25 const extensions::ExtensionSet& extension_set =
23 extensions::ExtensionRegistry::Get(profile_)->enabled_extensions(); 26 extensions::ExtensionRegistry::Get(profile_)->enabled_extensions();
24 for (extensions::ExtensionSet::const_iterator i = extension_set.begin(); 27 for (extensions::ExtensionSet::const_iterator i = extension_set.begin();
25 i != extension_set.end(); ++i) { 28 i != extension_set.end(); ++i) {
26 if (extensions::UIOverrides::RemovesBookmarkButton(i->get()) && 29 if (extensions::UIOverrides::RemovesBookmarkButton(i->get()) &&
27 ((*i)->permissions_data()->HasAPIPermission( 30 ((*i)->permissions_data()->HasAPIPermission(
28 extensions::APIPermission::kBookmarkManagerPrivate) || 31 extensions::APIPermission::kBookmarkManagerPrivate) ||
29 extensions::FeatureSwitch::enable_override_bookmarks_ui() 32 extensions::FeatureSwitch::enable_override_bookmarks_ui()
30 ->IsEnabled())) 33 ->IsEnabled()))
31 return true; 34 return true;
32 } 35 }
33 36
34 return false; 37 return false;
35 } 38 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698