Issue 243088: Add support for flaky tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 243088: Add support for flaky tests. (Closed)

Created:
11 years, 2 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add support for flaky gtests. BUG:21793 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27957

Patch Set 1 #

Total comments: 5

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -0 lines)			Patch
	M	base/test_suite.h	View	1	3 chunks	+45 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 2 months ago (2009-10-03 21:11:24 UTC) #2

lgtm

http://codereview.chromium.org/243088/diff/1/2
File base/test_suite.h (right):

http://codereview.chromium.org/243088/diff/1/2#newcode78
Line 78: // Returns true if a string starts with FLAKY_
// Returns true if a string starts with FLAKY_. This is the signal used to mark
a test as flaky.

http://codereview.chromium.org/243088/diff/1/2#newcode83
Line 83: typedef bool (*TestMatch)(const testing::TestInfo&);
Move this typedef at its right place.

http://codereview.chromium.org/243088/diff/1/2#newcode94
Line 94: // Returns the count of tests for the given test function.
isssh. Maybe a sentence where the meaning of the word 'test' is not different
each time? :)
// Counts the individual tests matching the condition test_match.

http://codereview.chromium.org/243088/diff/1/2#newcode102
Line 102: const testing::TestInfo& test = *test_case.GetTestInfo(j);
if (test_match(*test_case.GetTestInfo(j)))

http://codereview.chromium.org/243088/diff/1/2#newcode104
Line 104: count++;
-2

Expand Messages | Collapse Messages