Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2430803003:
Cleanup/ Remove linked_ptr from gin_java_base_object.h/cc (Closed)
DescriptionRemove linked_ptr from gin_java_base_object.h/cc
BUG=556939
Committed: https://crrev.com/9029a43f6b27d1982e6261bd322ef961cc930d66
Cr-Commit-Position: refs/heads/master@{#427059}
Patch Set 1 #
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by limasdf@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by limasdf@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by limasdf@gmail.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove linked_ptr from gin_java_base_object BUG= ========== to ========== Remove linked_ptr from gin_java_base_object.h/cc BUG=556939 ==========
limasdf@gmail.com changed reviewers: + torne@chromium.org
Torne, could you take a look?
kindly ping
LGTM (sorry, was OOO last week)
The CQ bit was checked by limasdf@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove linked_ptr from gin_java_base_object.h/cc BUG=556939 ========== to ========== Remove linked_ptr from gin_java_base_object.h/cc BUG=556939 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove linked_ptr from gin_java_base_object.h/cc BUG=556939 ========== to ========== Remove linked_ptr from gin_java_base_object.h/cc BUG=556939 Committed: https://crrev.com/9029a43f6b27d1982e6261bd322ef961cc930d66 Cr-Commit-Position: refs/heads/master@{#427059} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9029a43f6b27d1982e6261bd322ef961cc930d66 Cr-Commit-Position: refs/heads/master@{#427059} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
