core/fpdfapi/parser/fpdf_parser_utility.cpp - Issue 2430743003: in the attempt to fix 627393, changed IFX_FileRead's readBlock to return the length it reads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/fpdf_parser_utility.cpp

Issue 2430743003: in the attempt to fix 627393, changed IFX_FileRead's readBlock to return the length it reads

Patch Set: delete the include folder Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/fpdf_parser_utility.cpp

diff --git a/core/fpdfapi/parser/fpdf_parser_utility.cpp b/core/fpdfapi/parser/fpdf_parser_utility.cpp

index 630754a23b4ce3607486d5998fffba0a002f05b1..d7f62b1096991801662ac0d2e4586cb9d0d5d730 100644

--- a/core/fpdfapi/parser/fpdf_parser_utility.cpp

+++ b/core/fpdfapi/parser/fpdf_parser_utility.cpp

@@ -72,7 +72,7 @@ int32_t GetHeaderOffset(IFX_SeekableReadStream* pFile) {

const size_t kBufSize = 4;

uint8_t buf[kBufSize];

for (int32_t offset = 0; offset <= 1024; ++offset) {

- if (!pFile->ReadBlock(buf, offset, kBufSize))

+ if (pFile->ReadBlock(buf, offset, kBufSize) != kBufSize && !pFile->IsEOF())

return -1;

if (memcmp(buf, "%PDF", 4) == 0)

Tom Sepez 2016/11/14 20:27:40 might not have read 4 bytes if EOF.