Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp

Issue 2430743003: in the attempt to fix 627393, changed IFX_FileRead's readBlock to return the length it reads
Patch Set: remove .tmp files Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
diff --git a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
index d29b9834fa1e731e0e0ee48e67556da4fe0e2405..80fb3a4edfba2da99dcbbb37bc31f9cf570b26d7 100644
--- a/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
+++ b/core/fpdfapi/fpdf_edit/fpdf_edit_create.cpp
@@ -1495,7 +1495,9 @@ int32_t CPDF_Creator::WriteDoc_Stage1(IFX_Pause* pPause) {
uint32_t src_size = (uint32_t)(uintptr_t)m_Pos;
while (src_size) {
uint32_t block_size = src_size > 4096 ? 4096 : src_size;
- if (!pSrcFile->ReadBlock(buffer, m_Offset - src_size, block_size)) {
+ if (pSrcFile->ReadBlock(buffer, m_Offset - src_size, block_size) !=
+ block_size &&
+ !pSrcFile->IsEOF()) {
return -1;
}
if (m_File.AppendBlock(buffer, block_size) < 0) {
« no previous file with comments | « no previous file | core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp » ('j') | core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698