Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2430743002: [Android NTP] Cache children in SuggestionsSection. (Closed)

Created:
4 years, 2 months ago by Bernhard Bauer
Modified:
4 years, 2 months ago
Reviewers:
PEConn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android NTP] Cache children in SuggestionsSection. BUG=616090 Committed: https://crrev.com/05b98986c694ea4f26c8027665e8a3694ab199d0 Cr-Commit-Position: refs/heads/master@{#426153}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java View 1 5 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 2 months ago (2016-10-18 16:47:45 UTC) #4
PEConn
LGTM https://codereview.chromium.org/2430743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java (right): https://codereview.chromium.org/2430743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:74: nit: remove empty line
4 years, 2 months ago (2016-10-19 09:21:59 UTC) #7
Bernhard Bauer
https://codereview.chromium.org/2430743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java (right): https://codereview.chromium.org/2430743002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java#newcode74 chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java:74: On 2016/10/19 09:21:59, PEConn wrote: > nit: remove empty ...
4 years, 2 months ago (2016-10-19 10:07:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430743002/20001
4 years, 2 months ago (2016-10-19 10:08:30 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-19 11:52:01 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:07:08 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/05b98986c694ea4f26c8027665e8a3694ab199d0
Cr-Commit-Position: refs/heads/master@{#426153}

Powered by Google App Engine
This is Rietveld 408576698