Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2430723002: Extract ElementBuilder tests into a separate file. (Closed)

Created:
4 years, 2 months ago by scheglov
Modified:
4 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4452 lines) Patch
A + pkg/analyzer/test/dart/element/builder_test.dart View 2 chunks +3 lines, -2253 lines 0 comments Download
M pkg/analyzer/test/dart/element/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 3 chunks +0 lines, -2199 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 2 months ago (2016-10-18 15:31:30 UTC) #1
Brian Wilkerson
lgtm
4 years, 2 months ago (2016-10-18 17:18:45 UTC) #2
scheglov
4 years, 2 months ago (2016-10-18 17:22:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13d2420a3d758d7122e44599c6ec0848fc6eb90b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698