Property extraction getters (tear-offs) are effect-free

Property extraction getters (tear-offs) are effect-free

This mostly allows better scheduling of the surrounding instructions.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/5a646b782736189e105c32a50c364a9431afe8c8

[sra1, 2016-10-18 16:46:42]

Patchset #1 (id:1) has been deleted

[sra1, 2016-10-18 23:18:21]

sra@google.com changed reviewers:
+ johnniwinther@google.com, sigmund@google.com

[sra1, 2016-10-18 23:18:22]

Example:

    _ForwardingStreamSubscription$5: function(_stream, onData, onError, onDone,
cancelOnError, $S, $T) {
      var t1, t2;
      t1 = this.get$_handleData();
      t2 = this.get$_handleError();
      this._subscription =
this._stream._async$_source.listen$3$onDone$onError(t1, this.get$_handleDone(),
t2);
    },

--->

    _ForwardingStreamSubscription$5: function(_stream, onData, onError, onDone,
cancelOnError, $S, $T) {
      this._subscription =
this._stream._async$_source.listen$3$onDone$onError(this.get$_handleData(),
this.get$_handleDone(), this.get$_handleError());
    },

----

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1727: // represents two targets - a
tearoff getter and the torn-off method.
johnni: is this the right way to handle this?

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:1086: inputs,
This is to avoid the formatter bug
https://github.com/dart-lang/dart_style/issues/543

[Siggi Cherem (dart-lang), 2016-10-18 23:26:02]

lgtm

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/nodes.dart:1633: bool canThrow() => isTearOff ?
inputs.last.canBeNull() : super.canThrow();
inputs should be a single element right? maybe do inputs.single?

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:915: // TODO(sra): Also setUseGvn() to
allow tear-offs to be shared.
anything blocking this now? or is this just to keep the two changes separate?

[sra1, 2016-10-19 02:16:57]

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/nodes.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/nodes.dart:1633: bool canThrow() => isTearOff ?
inputs.last.canBeNull() : super.canThrow();
On 2016/10/18 23:26:02, Siggi Cherem (dart-lang) wrote:
> inputs should be a single element right? maybe do inputs.single?

There might be an interceptor, e.g  [].add;
'getDartReceiver' takes the 'compiler'.
I'll add a comment.

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/optimize.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/optimize.dart:915: // TODO(sra): Also setUseGvn() to
allow tear-offs to be shared.
On 2016/10/18 23:26:02, Siggi Cherem (dart-lang) wrote:
> anything blocking this now? or is this just to keep the two changes separate?

I'll do it

[sra1, 2016-10-19 03:13:36]

Description was changed from

==========
Property extraction getters (tear-offs) are effect-free

This mostly allows better scheduling of the surrounding instructions.
==========

to

==========
Property extraction getters (tear-offs) are effect-free

This mostly allows better scheduling of the surrounding instructions.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5a646b782736189e105c32a50c364a9431afe8c8
==========

[sra1, 2016-10-19 03:13:37]

Committed patchset #4 (id:80001) manually as
5a646b782736189e105c32a50c364a9431afe8c8 (presubmit successful).

[Johnni Winther, 2016-10-19 12:04:50]

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
File pkg/compiler/lib/src/ssa/codegen.dart (right):

https://codereview.chromium.org/2430683003/diff/80001/pkg/compiler/lib/src/ss...
pkg/compiler/lib/src/ssa/codegen.dart:1727: // represents two targets - a
tearoff getter and the torn-off method.
On 2016/10/18 23:18:22, sra1 wrote:
> johnni: is this the right way to handle this?

Yes.