Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2430623002: Reland: ChromeOS: Add unittest for ConvertPathToArcUrl. (Closed)

Created:
4 years, 2 months ago by kinaba
Modified:
4 years, 2 months ago
Reviewers:
fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, fukino+watch_chromium.org, davemoore+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: ChromeOS: Add unittest for ConvertPathToArcUrl. Relanding the reverted crrev.com/2429533004 commit. It broke the test due to the lack of message loop necessary for shutdown. This version now adds the test thread bundle. BUG=612720 TEST=unit_tests --gtest_filter='FileManagerPathUtilTest.ConvertPathToArcUrl' Committed: https://crrev.com/98c1b1af04fc6704666c3ac140542bb51d45cb90 Cr-Commit-Position: refs/heads/master@{#425923}

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/path_util_unittest.cc View 1 2 chunks +54 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kinaba
PTAL: fukino. Sorry for bothering you multiple times. The diff is between PS1 and PS2. ...
4 years, 2 months ago (2016-10-18 07:37:32 UTC) #4
fukino
lgtm Thank you for uploading two PSs to see the diff easier!
4 years, 2 months ago (2016-10-18 08:16:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430623002/20001
4 years, 2 months ago (2016-10-18 08:30:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 08:35:05 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:36:39 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/98c1b1af04fc6704666c3ac140542bb51d45cb90
Cr-Commit-Position: refs/heads/master@{#425923}

Powered by Google App Engine
This is Rietveld 408576698