Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2430613003: X87: [ic] Delete old KeyedLoadIC code. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [ic] Delete old KeyedLoadIC code. port 3f6e0a4ef92bf7859f42d20c8ff3e31a2e5acc0f (r40354) original commit message: RIP, handwritten KeyedLoadICStub, handwritten KeyedLoadIC_Megamorphic, and hydrogenized KeyedLoadGeneric! BUG= Committed: https://crrev.com/a05f85a3db33860f7f9651d904fd4193ee757848 Cr-Commit-Position: refs/heads/master@{#40388}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -111 lines) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-18 07:22:26 UTC) #2
Weiliang
lgtm
4 years, 2 months ago (2016-10-18 07:47:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430613003/1
4 years, 2 months ago (2016-10-18 08:04:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 08:29:34 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 08:30:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a05f85a3db33860f7f9651d904fd4193ee757848
Cr-Commit-Position: refs/heads/master@{#40388}

Powered by Google App Engine
This is Rietveld 408576698