Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 243059: Update some strings in the options dialog w.r.t. themes. (Closed)

Created:
11 years, 2 months ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Update some strings in the options dialog w.r.t. themes. Changed the heading from Themes: to Appearance: and switch from 'Set to XXX theme' to 'Use XXX theme'. BUG=21504 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27783

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +11 lines, -6 lines 0 comments Download
M chrome/browser/gtk/options/content_page_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 2 months ago (2009-10-01 19:02:05 UTC) #1
Elliot Glaysher
LGTM On Thu, Oct 1, 2009 at 12:02 PM, <tony@chromium.org> wrote: > Reviewers: Evan Stade, ...
11 years, 2 months ago (2009-10-01 19:06:29 UTC) #2
Evan Stade
11 years, 2 months ago (2009-10-01 19:33:00 UTC) #3 
lgtm

-- Evan Stade



On Thu, Oct 1, 2009 at 12:06 PM, Elliot Glaysher (Chromium)
<erg@chromium.org> wrote:
> LGTM
>
> On Thu, Oct 1, 2009 at 12:02 PM, =A0<tony@chromium.org> wrote:
>> Reviewers: Evan Stade, Evan Martin, Elliot Glaysher,
>>
>> Description:
>> Update some strings in the options dialog w.r.t. themes.
>>
>> Changed the heading from Themes: to Appearance: and switch
>> from 'Set to XXX theme' to 'Use XXX theme'.
>>
>> BUG=3D21504
>>
>> Please review this at http://codereview.chromium.org/243059
>>
>> Affected files:
>> =A0M chrome/app/generated_resources.grd
>> =A0M chrome/browser/gtk/options/content_page_gtk.cc
>>
>>
>> Index: chrome/app/generated_resources.grd
>> diff --git a/chrome/app/generated_resources.grd
>> b/chrome/app/generated_resources.grd
>> index
>> 49defb4764a2d4817f2c8ee6efef07c5127d138d..07fd1b0257f11c0141d6b1b0e10f41=
6cf4cacc66
>> 100644
>> --- a/chrome/app/generated_resources.grd
>> +++ b/chrome/app/generated_resources.grd
>> @@ -4005,12 +4005,17 @@ Keep your key file in a safe place. You will nee=
d it
>> to create new versions of y
>> =A0 =A0 =A0 <message name=3D"IDS_THEMES_GROUP_NAME" desc=3D"The title of=
 the themes
>> group">
>> =A0 =A0 =A0 =A0 Themes:
>> =A0 =A0 =A0 </message>
>> - =A0 =A0 =A0<message name=3D"IDS_THEMES_GTK_BUTTON" desc=3D"The button =
to choose GTK
>> colors and icons as the current theme.">
>> - =A0 =A0 =A0 =A0Set to GTK+ theme
>> - =A0 =A0 =A0</message>
>> - =A0 =A0 =A0<message name=3D"IDS_THEMES_SET_CLASSIC" desc=3D"The button=
 to choose the
>> classic windows theme in GTK">
>> - =A0 =A0 =A0 =A0 =A0 Set to Classic theme
>> - =A0 =A0 =A0</message>
>> + =A0 =A0 =A0<if expr=3D"os =3D=3D 'linux2'">
>> + =A0 =A0 =A0 =A0<message name=3D"IDS_APPEARANCE_GROUP_NAME" desc=3D"The=
 title of the
>> themes group">
>> + =A0 =A0 =A0 =A0 =A0Appearance:
>> + =A0 =A0 =A0 =A0</message>
>> + =A0 =A0 =A0 =A0<message name=3D"IDS_THEMES_GTK_BUTTON" desc=3D"The but=
ton to choose
>> GTK colors and icons as the current theme.">
>> + =A0 =A0 =A0 =A0 =A0Use GTK+ theme
>> + =A0 =A0 =A0 =A0</message>
>> + =A0 =A0 =A0 =A0<message name=3D"IDS_THEMES_SET_CLASSIC" desc=3D"The bu=
tton to choose
>> the classic windows theme in GTK">
>> + =A0 =A0 =A0 =A0 =A0Use Classic theme
>> + =A0 =A0 =A0 =A0</message>
>> + =A0 =A0 =A0</if>
>> =A0 =A0 =A0 <message name=3D"IDS_THEMES_RESET_BUTTON" desc=3D"The button=
 to reset your
>> theme">
>> =A0 =A0 =A0 =A0 Reset to default theme
>> =A0 =A0 =A0 </message>
>> Index: chrome/browser/gtk/options/content_page_gtk.cc
>> diff --git a/chrome/browser/gtk/options/content_page_gtk.cc
>> b/chrome/browser/gtk/options/content_page_gtk.cc
>> index
>> 8098a1b278bc6c14e53a77df79221055acfea6b6..6c9b4d2532236ae3acce25b562c421=
429673ab22
>> 100644
>> --- a/chrome/browser/gtk/options/content_page_gtk.cc
>> +++ b/chrome/browser/gtk/options/content_page_gtk.cc
>> @@ -43,7 +43,7 @@ ContentPageGtk::ContentPageGtk(Profile* profile)
>> =A0 =A0 =A0 l10n_util::GetStringUTF8(IDS_OPTIONS_BROWSING_DATA_GROUP_NAM=
E),
>> =A0 =A0 =A0 InitBrowsingDataGroup(), false);
>> =A0 options_builder.AddOptionGroup(
>> - =A0 =A0 =A0l10n_util::GetStringUTF8(IDS_THEMES_GROUP_NAME),
>> + =A0 =A0 =A0l10n_util::GetStringUTF8(IDS_APPEARANCE_GROUP_NAME),
>> =A0 =A0 =A0 InitThemesGroup(), false);
>> =A0 page_ =3D options_builder.get_page_widget();
>>
>>
>>
>>
>

Powered by Google App Engine
This is Rietveld 408576698