Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2430583002: Add a test case for bug 494057. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Add a test case for bug 494057. The expectation is set incorrectly to allow the test to pass. BUG=chromium:494057 Committed: https://pdfium.googlesource.com/pdfium/+/f3c5fc09f0818ec378890ade42bef40eebd3f0a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
A + testing/resources/javascript/bug_494057.in View 1 chunk +10 lines, -20 lines 0 comments Download
A testing/resources/javascript/bug_494057_expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
4 years, 2 months ago (2016-10-18 00:14:10 UTC) #4
dsinclair
lgtm
4 years, 2 months ago (2016-10-18 13:21:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430583002/1
4 years, 2 months ago (2016-10-18 13:21:40 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 13:22:01 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f3c5fc09f0818ec378890ade42bef40eebd3...

Powered by Google App Engine
This is Rietveld 408576698