Merge IFWL_App and FWL_AppImp together

Merge IFWL_App and FWL_AppImp together

The IFWL_App class just acts as a proxy to the FWL_AppImp code. This Cl removes
FWL_AppImp and merges the code back up to IFWL_App, simplifying the
object hierarchy.

Committed: https://pdfium.googlesource.com/pdfium/+/4e903136cf0f02578c0e47c6738b633c96814b62

[dsinclair, 2016-10-18 13:15:23]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 13:15:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-10-18 13:15:38]

dsinclair@chromium.org changed reviewers:
+ npm@chromium.org, thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-10-18 13:15:38]

PTAL.

[commit-bot: I haz the power, 2016-10-18 13:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 13:28:00]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-10-18 16:48:15]

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetimp.cpp (left):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetimp.cpp:645: return FWL_GetApp()->GetThemeProvider();
Always nullptr?

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:30: class IFWL_App {
Is this going to get renamed later?

[dsinclair, 2016-10-18 17:00:22]

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/fwl_widget...
File xfa/fwl/core/fwl_widgetimp.cpp (left):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/fwl_widget...
xfa/fwl/core/fwl_widgetimp.cpp:645: return FWL_GetApp()->GetThemeProvider();
On 2016/10/18 16:48:15, Lei Zhang wrote:
> Always nullptr?

Yes, there were no calls to SetThemeProvider that I found, so it was always
nullptr and has been removed.

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (right):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:30: class IFWL_App {
On 2016/10/18 16:48:15, Lei Zhang wrote:
> Is this going to get renamed later?


Probably, I'm saving that for once we've got the rest of the FWL classes sorted,
can figure out naming at that point.

[npm, 2016-10-18 17:04:11]

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (left):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:15: //                                       
<-----------
Do we still need a comment explaining how these classes work now?

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:53: void Exit(int32_t iExitCode);
So these three methods were simply unused?

[dsinclair, 2016-10-18 17:08:27]

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h
File xfa/fwl/core/ifwl_app.h (left):

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:15: //                                       
<-----------
On 2016/10/18 17:04:11, npm wrote:
> Do we still need a comment explaining how these classes work now?


I don't think so, now it's just CXFA_FFApp -> IFWL_App which is a fairly normal
thing to do.

https://codereview.chromium.org/2430563003/diff/20001/xfa/fwl/core/ifwl_app.h...
xfa/fwl/core/ifwl_app.h:53: void Exit(int32_t iExitCode);
On 2016/10/18 17:04:11, npm wrote:
> So these three methods were simply unused?


GetThemeProvider was used but it always returned nullptr because
SetThemeProvider is never called.

Exit was never called.

[npm, 2016-10-18 19:05:10]

lgtm

[dsinclair, 2016-10-18 23:47:57]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:47:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 23:48:18]

Description was changed from

==========
Merge IFWL_App and FWL_AppImp together

The IFWL_App class just acts as a proxy to the FWL_AppImp code. This Cl removes
FWL_AppImp and merges the code back up to IFWL_App, simplifying the
object hierarchy.
==========

to

==========
Merge IFWL_App and FWL_AppImp together

The IFWL_App class just acts as a proxy to the FWL_AppImp code. This Cl removes
FWL_AppImp and merges the code back up to IFWL_App, simplifying the
object hierarchy.

Committed:
https://pdfium.googlesource.com/pdfium/+/4e903136cf0f02578c0e47c6738b633c9681...
==========

[commit-bot: I haz the power, 2016-10-18 23:48:19]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/4e903136cf0f02578c0e47c6738b633c9681...