Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2430523004: Remove unnecessary rev_str variable from gclient_scm (Closed)

Created:
4 years, 2 months ago by agable
Modified:
4 years, 1 month ago
Reviewers:
iannucci
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unnecessary rev_str variable from gclient_scm Some initial cleanup before larger refactorings. R=iannucci@chromium.org BUG=643346 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/83faed04862b6c6b7b2034bb256687afeb9d31c0

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M gclient_scm.py View 1 13 chunks +25 lines, -24 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
agable
4 years, 2 months ago (2016-10-18 22:01:03 UTC) #1
iannucci
lgtm
4 years, 2 months ago (2016-10-19 16:25:05 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2395013002 Patch 40001). Please resolve the dependency and ...
4 years, 1 month ago (2016-10-24 21:30:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430523004/20001
4 years, 1 month ago (2016-10-24 21:33:40 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 21:37:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/83faed04862b6c...

Powered by Google App Engine
This is Rietveld 408576698