chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h - Issue 2430493002: [Mac] Fix rough-looking profile picker text, especially with a dark theme.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/tabs/tab_strip_background_view.h

Issue 2430493002: [Mac] Fix rough-looking profile picker text, especially with a dark theme. (Closed)

Patch Set: Add theme tests Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« base/mac/sdk_forward_declarations.h ('K') | « chrome/browser/ui/cocoa/floating_bar_backing_view.mm ('k') | chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm » ('j') | chrome/browser/ui/cocoa/tabs/tab_strip_background_view.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_	5 #ifndef CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_

6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_	6 #define CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_

7	7

8 #import <Cocoa/Cocoa.h>	8 #import <Cocoa/Cocoa.h>

9	9

10 #import "chrome/browser/ui/cocoa/themed_window.h"	10 @class TabStripBackgroundView;
	Robert Sesek 2017/01/11 19:23:39 Not used? Not used? Sidney San Martín 2017/01/13 00:10:07 Done. Show quoted text On 2017/01/11 19:23:39, Robert Sesek wrote: > Not used? Done.
11	11

12 // A view that draws the theme image in the top area of the window (behind the	12 // A view that draws the theme and transparency effects behind the tab strip.

13 // tab strip area). It should be arranged so that its z-order is below its	13 // It should be behind its overlapping sibling views (window controls, tab

14 // overlapping sibling views (window controls, tab strip view, profile button	14 // strip view, profile button and fullscreen button).

15 // and fullscreen button).	15 @interface TabStripBackgroundView : NSView

16 @interface TabStripBackgroundView : NSView<ThemedWindowDrawing>	16 @property(nonatomic) BOOL inATabDraggingOverlayWindow;

17 @end	17 @end

18	18

19 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_	19 #endif // CHROME_BROWSER_UI_COCOA_TABS_TAB_STRIP_BACKGROUND_VIEW_H_

OLD	NEW