[Mac] Fix rough-looking profile picker text, especially with a dark theme.

base/mac/sdk_forward_declarations.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains forward declarations for items in later SDKs than the
 // default one with which Chromium is built (currently 10.10).
 // If you call any function from this header, be sure to check at runtime for
 // respondsToSelector: before calling these functions (else your code will crash
 // on older OS X versions that chrome still supports).
 
@@ skipping 58 matching lines @@
 
 // ----------------------------------------------------------------------------
 // Define NSStrings only available in newer versions of the OSX SDK to force
 // them to be statically linked.
 // ----------------------------------------------------------------------------
 
 extern "C" {
 #if !defined(MAC_OS_X_VERSION_10_10) || \
     MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_10
 BASE_EXPORT extern NSString* const NSUserActivityTypeBrowsingWeb;
-BASE_EXPORT extern NSString* const NSAppearanceNameVibrantDark;

[Robert Sesek, 2017/01/11 19:23:39]

Why are you removing these from here?

[Sidney San Martín, 2017/01/11 22:00:58]

Maybe we can chat about this in person with thakis@? I think that if the intent
of -Wunguarded-availability is for you to not use partially-available symbols by
accident, then the number of symbols in sdk_forward_declarations.h is inversely
correlated with the diagnostic being useful.

I wanted to avoid putting new related symbols in this header, especially ones
that are only used in one file, so I put them all in the same place.

[Robert Sesek, 2017/01/11 22:09:54]

Hm yes let's chat in person.

-BASE_EXPORT extern NSString* const NSAppearanceNameVibrantLight;
 #endif  // MAC_OS_X_VERSION_10_10
 }  // extern "C"
 
 // ----------------------------------------------------------------------------
 // If compiling against an older version of the OSX SDK, declare classes and
 // functions that are available in newer versions of the OSX SDK. If compiling
 // against a newer version of the OSX SDK, redeclare those same classes and
 // functions to suppress -Wpartial-availability warnings.
 // ----------------------------------------------------------------------------
 
@@ skipping 24 matching lines @@
 @end
 
 @interface NSProcessInfo (YosemiteSDK)
 @property(readonly) NSOperatingSystemVersion operatingSystemVersion;
 @end
 
 @interface NSLayoutConstraint (YosemiteSDK)
 @property(getter=isActive) BOOL active;
 @end
 
-@interface NSVisualEffectView (YosemiteSDK)
-- (void)setState:(NSVisualEffectState)state;
-@end
-
-@class NSVisualEffectView;
-
 #endif  // MAC_OS_X_VERSION_10_10
 
 // Once Chrome no longer supports OSX 10.10.2, everything within this
 // preprocessor block can be removed.
 #if !defined(MAC_OS_X_VERSION_10_10_3) || \
     MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_10_3
 
 @interface NSEvent (YosemiteSDK)
 @property(readonly) NSInteger stage;
 @end
@@ skipping 51 matching lines @@
 
 // ----------------------------------------------------------------------------
 // The symbol for kCWSSIDDidChangeNotification is available in the
 // CoreWLAN.framework for OSX versions 10.6 through 10.10. The symbol is not
 // declared in the OSX 10.9+ SDK, so when compiling against an OSX 10.9+ SDK,
 // declare the symbol.
 // ----------------------------------------------------------------------------
 BASE_EXPORT extern "C" NSString* const kCWSSIDDidChangeNotification;
 
 #endif  // BASE_MAC_SDK_FORWARD_DECLARATIONS_H_