Removed use of IsRunningOnIOS8OrLater from ui_util and uikit_ui_util

ios/chrome/browser/ui/uikit_ui_util.mm

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 
 #import <Accelerate/Accelerate.h>
 #import <Foundation/Foundation.h>
 #import <QuartzCore/QuartzCore.h>
 #include <stddef.h>
@@ skipping 436 matching lines @@
   UIImage* result = [UIImage imageWithCGImage:cgImage];
   CGImageRelease(cgImage);
   return result;
 }
 
 UIInterfaceOrientation GetInterfaceOrientation() {
   return [[UIApplication sharedApplication] statusBarOrientation];
 }
 
 CGFloat CurrentKeyboardHeight(NSValue* keyboardFrameValue) {
   CGSize keyboardSize = [keyboardFrameValue CGRectValue].size;

[justincohen, 2016/10/18 10:59:20]

return [keyboardFrameValue CGRectValue].size.height ?

[pkl (ping after 24h if needed), 2016/10/19 18:47:32]

Done.

-  if (base::ios::IsRunningOnIOS8OrLater()) {
-    return keyboardSize.height;
-  } else {
-    return IsPortrait() ? keyboardSize.height : keyboardSize.width;
-  }
+  return keyboardSize.height;
 }
 
 UIImage* ImageWithColor(UIColor* color) {
   CGRect rect = CGRectMake(0, 0, 1, 1);
   UIGraphicsBeginImageContext(rect.size);
   CGContextRef context = UIGraphicsGetCurrentContext();
   CGContextSetFillColorWithColor(context, [color CGColor]);
   CGContextFillRect(context, rect);
   UIImage* image = UIGraphicsGetImageFromCurrentImageContext();
   UIGraphicsEndImageContext();
@@ skipping 138 matching lines @@
 void AddSameSizeConstraint(UIView* view1, UIView* view2) {
   [NSLayoutConstraint activateConstraints:@[
     [view1.leadingAnchor constraintEqualToAnchor:view2.leadingAnchor],
     [view1.trailingAnchor constraintEqualToAnchor:view2.trailingAnchor],
     [view1.topAnchor constraintEqualToAnchor:view2.topAnchor],
     [view1.bottomAnchor constraintEqualToAnchor:view2.bottomAnchor]
   ]];
 }
 
 bool IsCompact(id<UITraitEnvironment> environment) {
-  if (base::ios::IsRunningOnIOS8OrLater()) {
-    return environment.traitCollection.horizontalSizeClass ==
-           UIUserInterfaceSizeClassCompact;
-  } else {
-    // Prior to iOS 8, iPad is always regular, iPhone is always compact.
-    return !IsIPadIdiom();
-  }
+  return environment.traitCollection.horizontalSizeClass ==
+         UIUserInterfaceSizeClassCompact;
 }
 
 bool IsCompact() {
   UIWindow* keyWindow = [UIApplication sharedApplication].keyWindow;
   return IsCompact(keyWindow);
 }
 
 bool IsCompactTablet(id<UITraitEnvironment> environment) {
   return IsIPadIdiom() && IsCompact(environment);
 }
 
 bool IsCompactTablet() {
   return IsIPadIdiom() && IsCompact();
 }
 
 // Returns the current first responder.
 UIResponder* GetFirstResponder() {
   DCHECK_CURRENTLY_ON(web::WebThread::UI);
   DCHECK(!gFirstResponder);
   [[UIApplication sharedApplication]
       sendAction:@selector(cr_markSelfCurrentFirstResponder)
               to:nil
             from:nil
         forEvent:nil];
   UIResponder* firstResponder = gFirstResponder;
   gFirstResponder = nil;
   return firstResponder;
 }