Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6148)

Unified Diff: chrome/common/extensions/api/settings_private.idl

Issue 2430463002: MD Settings: tweak some chrome.settingsPrivate method names (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/settings_private.idl
diff --git a/chrome/common/extensions/api/settings_private.idl b/chrome/common/extensions/api/settings_private.idl
index 287f1d1fedb5ee9d85a22d38e2a4ef0dc870c454..307d332fd10d393121adf9449dee2d709c5654f5 100644
--- a/chrome/common/extensions/api/settings_private.idl
+++ b/chrome/common/extensions/api/settings_private.idl
@@ -57,8 +57,8 @@ namespace settingsPrivate {
callback OnPrefSetCallback = void (boolean success);
callback GetAllPrefsCallback = void (PrefObject[] prefs);
callback GetPrefCallback = void (PrefObject pref);
- callback GetDefaultZoomPercentCallback = void (double percent);
- callback SetDefaultZoomPercentCallback = void (boolean success);
+ callback GetDefaultZoomCallback = void (double zoom);
+ callback SetDefaultZoomCallback = void (boolean success);
interface Functions {
// Sets a settings value.
@@ -75,12 +75,12 @@ namespace settingsPrivate {
// Gets the value of a specific pref.
static void getPref(DOMString name, GetPrefCallback callback);
- // Gets the page zoom factor as an integer percentage.
- static void getDefaultZoomPercent(GetDefaultZoomPercentCallback callback);
+ // Gets the page zoom factor.
Devlin 2016/10/17 19:28:24 Here and below, can you define what the zoom is in
Dan Beam 2016/10/17 21:09:00 Done.
+ static void getDefaultZoom(GetDefaultZoomCallback callback);
- // Sets the page zoom factor from a zoom percentage.
- static void setDefaultZoomPercent(double percent,
- optional SetDefaultZoomPercentCallback callback);
+ // Sets the page zoom factor.
+ static void setDefaultZoom(double zoom,
+ optional SetDefaultZoomCallback callback);
Devlin 2016/10/17 19:28:24 Since you're touching this line anyway, mind adjus
Dan Beam 2016/10/17 21:09:00 Done.
};
interface Events {

Powered by Google App Engine
This is Rietveld 408576698