MD Settings: tweak some chrome.settingsPrivate method names

MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/eb9b71b64bca4d82a04696940a7896695ed87b79
Cr-Commit-Position: refs/heads/master@{#426008}

[Dan Beam, 2016-10-17 19:18:37]

Description was changed from

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org
BUG=none
==========

to

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-17 19:20:53]

Description was changed from

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2016-10-17 19:20:53]

dbeam@chromium.org changed reviewers:
+ dpapad@chromium.org

[Dan Beam, 2016-10-17 19:21:54]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 19:22:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-10-17 19:28:24]

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/settings_private.idl (right):

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/settings_private.idl:78: // Gets the page zoom
factor.
Here and below, can you define what the zoom is in terms of?  (It's 0 - 1 now,
right?  But it could be 0 - 100 with decimal accuracy in a crazier world.)

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/settings_private.idl:83: optional
SetDefaultZoomCallback callback);
Since you're touching this line anyway, mind adjusting indent?  All args should
be at the same indentation level or on the same line, so this should be either:
static void setDefaultZoom(
    double zoom, optional SetDefaultZoomCallback callback);
static void setDefaultZoom(
    double zoom,
    optional SetDefaultZoomCallback callback);

[commit-bot: I haz the power, 2016-10-17 19:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 19:36:05]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-10-17 19:51:23]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 19:51:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[michaelpg, 2016-10-17 20:02:36]

lgtm

[Dan Beam, 2016-10-17 21:09:01]

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
File chrome/common/extensions/api/settings_private.idl (right):

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/settings_private.idl:78: // Gets the page zoom
factor.
On 2016/10/17 19:28:24, Devlin wrote:
> Here and below, can you define what the zoom is in terms of?  (It's 0 - 1 now,
> right?  But it could be 0 - 100 with decimal accuracy in a crazier world.)

Done.

https://codereview.chromium.org/2430463002/diff/1/chrome/common/extensions/ap...
chrome/common/extensions/api/settings_private.idl:83: optional
SetDefaultZoomCallback callback);
On 2016/10/17 19:28:24, Devlin wrote:
> Since you're touching this line anyway, mind adjusting indent?  All args
should
> be at the same indentation level or on the same line, so this should be
either:
> static void setDefaultZoom(
>     double zoom, optional SetDefaultZoomCallback callback);
> static void setDefaultZoom(
>     double zoom,
>     optional SetDefaultZoomCallback callback);

Done.

[Devlin, 2016-10-17 21:21:05]

lgtm

[dpapad, 2016-10-17 21:26:38]

lgtm

[Dan Beam, 2016-10-17 21:41:52]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:42:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-10-17 22:57:06]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-10-17 22:57:13]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-10-17 22:57:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2430463002/#ps40001
(title: "rdevlin.cronin@")

[commit-bot: I haz the power, 2016-10-17 22:57:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 23:03:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:03:17]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dan Beam, 2016-10-17 23:18:09]

dbeam@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Dan Beam, 2016-10-17 23:18:10]

+asvitkine@ for extension_function_histogram_value.h stamp

(as yes, I read the top of the file and am intentionally doing a rename only,
it's the same method in a private extension API just with a slightly different
implementation, i.e. removing the *100 and /100)

[Alexei Svitkine (slow), 2016-10-18 14:07:36]

https://codereview.chromium.org/2430463002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/2430463002/diff/40001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1156:
SETTINGSPRIVATE_SETDEFAULTZOOMFUNCTION,
Please make the corresponding change to histograms.xml. Thanks!

[Dan Beam, 2016-10-18 16:13:01]

https://codereview.chromium.org/2430463002/diff/40001/extensions/browser/exte...
File extensions/browser/extension_function_histogram_value.h (right):

https://codereview.chromium.org/2430463002/diff/40001/extensions/browser/exte...
extensions/browser/extension_function_histogram_value.h:1156:
SETTINGSPRIVATE_SETDEFAULTZOOMFUNCTION,
On 2016/10/18 14:07:35, Alexei Svitkine (slow) wrote:
> Please make the corresponding change to histograms.xml. Thanks!

Done.

[Alexei Svitkine (slow), 2016-10-18 16:19:26]

lgtm

[Dan Beam, 2016-10-18 16:27:34]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 16:27:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-10-18 16:53:23]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2016-10-18 16:53:33]

The CQ bit was checked by dbeam@chromium.org

[Dan Beam, 2016-10-18 16:53:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, michaelpg@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2430463002/#ps60001
(title: "histograms.xml")

[commit-bot: I haz the power, 2016-10-18 16:53:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:56:35]

Description was changed from

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-18 17:56:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-18 18:52:57]

Description was changed from

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: tweak some chrome.settingsPrivate method names

R=michaelpg@chromium.org,rdevlin.cronin@chromium.org,dpapad@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/eb9b71b64bca4d82a04696940a7896695ed87b79
Cr-Commit-Position: refs/heads/master@{#426008}
==========

[commit-bot: I haz the power, 2016-10-18 18:52:58]

Patchset 4 (id:??) landed as
https://crrev.com/eb9b71b64bca4d82a04696940a7896695ed87b79
Cr-Commit-Position: refs/heads/master@{#426008}