Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2123)

Unified Diff: content/renderer/service_worker/embedded_worker_instance_client_impl.cc

Issue 2430403005: ServiceWorker: check if StopWorker is called twice (Closed)
Patch Set: Removed obvious DCHECKs Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/service_worker/embedded_worker_dispatcher.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/embedded_worker_instance_client_impl.cc
diff --git a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
index 4b399b8819280218acbf37621858e962e0783aed..d4f58838c4ada4707206166be215844648edb04b 100644
--- a/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
+++ b/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
@@ -69,7 +69,11 @@ void EmbeddedWorkerInstanceClientImpl::StopWorker(
const StopWorkerCallback& callback) {
DCHECK(ChildThreadImpl::current());
DCHECK(embedded_worker_id_);
- DCHECK(!stop_callback_);
+ // StopWorker is possible to be called twice.
+ if (stop_callback_) {
+ LOG(WARNING) << "Got StopWorker for stopping worker";
+ return;
+ }
TRACE_EVENT0("ServiceWorker", "EmbeddedWorkerInstanceClientImpl::StopWorker");
stop_callback_ = std::move(callback);
dispatcher_->RecordStopWorkerTimer(embedded_worker_id_.value());
« no previous file with comments | « content/renderer/service_worker/embedded_worker_dispatcher.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698