ServiceWorker: check if StopWorker is called twice

ServiceWorker: check if StopWorker is called twice

StopWorker might be called twice when a long running StartWorker triggers a
timeout handler on the browser process while SWVersion::StopWorker is already
enqueued.

BUG=657232
Committed: https://crrev.com/68901f8eedbd1b57de647f713198e9518d962ec0
Cr-Commit-Position: refs/heads/master@{#426707}

[shimazu, 2016-10-20 08:00:51]

shimazu@chromium.org changed reviewers:
+ nhiroki@chromium.org

[shimazu, 2016-10-20 08:00:51]

ptal:)

[nhiroki, 2016-10-20 09:22:11]

lgtm

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/embedded_worker_dispatcher.cc (right):

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
content/renderer/service_worker/embedded_worker_dispatcher.cc:85:
DCHECK(wrapper);
This DCHECK is obvious. Can you remove this?

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/embedded_worker_instance_client_impl.cc
(right):

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
content/renderer/service_worker/embedded_worker_instance_client_impl.cc:77:
DCHECK(!stop_callback_);
ditto.

[shimazu, 2016-10-21 01:17:03]

Thanks, updated.

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/embedded_worker_dispatcher.cc (right):

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
content/renderer/service_worker/embedded_worker_dispatcher.cc:85:
DCHECK(wrapper);
On 2016/10/20 09:22:11, nhiroki (slow) wrote:
> This DCHECK is obvious. Can you remove this?

Done.

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
File content/renderer/service_worker/embedded_worker_instance_client_impl.cc
(right):

https://codereview.chromium.org/2430403005/diff/1/content/renderer/service_wo...
content/renderer/service_worker/embedded_worker_instance_client_impl.cc:77:
DCHECK(!stop_callback_);
On 2016/10/20 09:22:11, nhiroki (slow) wrote:
> ditto.

Done.

[shimazu, 2016-10-21 01:17:16]

The CQ bit was checked by shimazu@chromium.org

[shimazu, 2016-10-21 01:17:16]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/2430403005/#ps20001
(title: "Removed obvious DCHECKs")

[commit-bot: I haz the power, 2016-10-21 01:18:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 02:51:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-21 13:26:44]

Description was changed from

==========
ServiceWorker: check if StopWorker is called twice

StopWorker might be called twice when a long running StartWorker triggers a
timeout handler on the browser process while SWVersion::StopWorker is already
enqueued.

BUG=657232
==========

to

==========
ServiceWorker: check if StopWorker is called twice

StopWorker might be called twice when a long running StartWorker triggers a
timeout handler on the browser process while SWVersion::StopWorker is already
enqueued.

BUG=657232

Committed: https://crrev.com/68901f8eedbd1b57de647f713198e9518d962ec0
Cr-Commit-Position: refs/heads/master@{#426707}
==========

[commit-bot: I haz the power, 2016-10-21 13:26:46]

Patchset 2 (id:??) landed as
https://crrev.com/68901f8eedbd1b57de647f713198e9518d962ec0
Cr-Commit-Position: refs/heads/master@{#426707}