Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2430403003: [Mac] Refactor the fullscreen toolbar animation (Closed)
Patch Set: Fix for rsesek Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 3f9f5a88871ab750d2c746cd009394b49cfe2330..546fa63014235a7662543906b402b3046cb6b926 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -1950,9 +1950,8 @@ willAnimateFromState:(BookmarkBar::State)oldState
// If enabled, show the overlay if necessary (and if the fullscreen
// toolbar is hidden).
- if (barVisibilityUpdatesEnabled_) {
- [fullscreenToolbarController_ lockBarVisibilityWithAnimation:animate];
- }
+ if (barVisibilityUpdatesEnabled_)
+ [fullscreenToolbarController_ ensureOverlayShownWithAnimation:animate];
}
}
@@ -1962,10 +1961,8 @@ willAnimateFromState:(BookmarkBar::State)oldState
// If enabled, hide the overlay if necessary (and if the fullscreen
// toolbar is hidden).
- if (barVisibilityUpdatesEnabled_ &&
- ![barVisibilityLocks_ count]) {
- [fullscreenToolbarController_ releaseBarVisibilityWithAnimation:animate];
- }
+ if (barVisibilityUpdatesEnabled_ && ![barVisibilityLocks_ count])
+ [fullscreenToolbarController_ ensureOverlayHiddenWithAnimation:animate];
}
}
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_animation_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698