Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1879)

Unified Diff: src/bootstrapper.cc

Issue 2430383004: Remove the 'caller' property from the strict-mode arguments map (Closed)
Patch Set: Remove the 'caller' property from the strict-mode arguments map Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/es6/classes.js » ('j') | test/webkit/fast/js/basic-strict-mode-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/bootstrapper.cc
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
index 02b2a240881a5a04a75a106eadb4ac44271fb29e..d2c8cb1de906a119ca2dccb2e9494f6715355c97 100644
--- a/src/bootstrapper.cc
+++ b/src/bootstrapper.cc
@@ -2511,23 +2511,20 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
const PropertyAttributes attributes =
static_cast<PropertyAttributes>(DONT_ENUM | DONT_DELETE | READ_ONLY);
- // Create the ThrowTypeError functions.
+ // Create the ThrowTypeError function.
Handle<AccessorPair> callee = factory->NewAccessorPair();
- Handle<AccessorPair> caller = factory->NewAccessorPair();
Handle<JSFunction> poison = GetStrictArgumentsPoisonFunction();
- // Install the ThrowTypeError functions.
+ // Install the ThrowTypeError function.
callee->set_getter(*poison);
callee->set_setter(*poison);
- caller->set_getter(*poison);
- caller->set_setter(*poison);
// Create the map. Allocate one in-object field for length.
Handle<Map> map = factory->NewMap(
JS_ARGUMENTS_TYPE, JSStrictArgumentsObject::kSize, FAST_ELEMENTS);
// Create the descriptor array for the arguments object.
- Map::EnsureDescriptorSlack(map, 3);
+ Map::EnsureDescriptorSlack(map, 2);
{ // length
DataDescriptor d(factory->length_string(),
@@ -2540,11 +2537,6 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
attributes);
map->AppendDescriptor(&d);
}
- { // caller
- AccessorConstantDescriptor d(factory->caller_string(), caller,
- attributes);
- map->AppendDescriptor(&d);
- }
// @@iterator method is added later.
DCHECK_EQ(native_context()->object_function()->prototype(),
« no previous file with comments | « no previous file | test/mjsunit/es6/classes.js » ('j') | test/webkit/fast/js/basic-strict-mode-expected.txt » ('J')

Powered by Google App Engine
This is Rietveld 408576698