Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/core/SkAnalyticEdge.h

Issue 2430343003: Use Analytic AA in SkAAClip (Closed)
Patch Set: Nit Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/core/SkAAClip.cpp ('K') | « src/core/SkAAClip.cpp ('k') | src/core/SkBitmapDevice.cpp » ('j') | src/core/SkScan_AAAPath.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkAnalyticEdge.h
diff --git a/src/core/SkAnalyticEdge.h b/src/core/SkAnalyticEdge.h
index f4b23ba2b6bd6ab77c5e0b2d0bc5aaeb1d291d96..cc07aec77063e74923e022a377af308b38074402 100644
--- a/src/core/SkAnalyticEdge.h
+++ b/src/core/SkAnalyticEdge.h
@@ -43,7 +43,9 @@ struct SkAnalyticEdge {
static const int kDefaultAccuracy = 2; // default accuracy for snapping
static inline SkFixed snapY(SkFixed y, int accuracy = kDefaultAccuracy) {
- return SkFixedRoundToFixed(y << accuracy) >> accuracy;
+ return (y + (SK_Fixed1 >> (accuracy + 1))) >> (16 - accuracy) << (16 - accuracy);
caryclark 2016/10/20 16:58:14 As I overheard mtklein say, this looks like a job
+ // The following does not work correctly for negative y. I've no idea why...
+ // return SkFixedRoundToFixed(y << accuracy) >> accuracy;
}
// Update fX, fY of this edge so fY = y
« src/core/SkAAClip.cpp ('K') | « src/core/SkAAClip.cpp ('k') | src/core/SkBitmapDevice.cpp » ('j') | src/core/SkScan_AAAPath.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698