Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 243033002: Switch CPU profile start/stop markers to monotonic time. (Closed)

Created:
6 years, 8 months ago by alph
Modified:
6 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Switch CPU profile start/stop markers to monotonic time. LOG=N BUG=363976 R=bmeurer@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20866

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M include/v8-profiler.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M src/api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/profile-generator.h View 2 chunks +4 lines, -5 lines 0 comments Download
M src/profile-generator.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
alph
Folks, could you please take a look.
6 years, 8 months ago (2014-04-18 12:34:46 UTC) #1
yurys
lgtm https://codereview.chromium.org/243033002/diff/1/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/243033002/diff/1/include/v8-profiler.h#newcode121 include/v8-profiler.h:121: * Returns time when the profile recording was ...
6 years, 8 months ago (2014-04-18 12:43:29 UTC) #2
alph
https://codereview.chromium.org/243033002/diff/1/include/v8-profiler.h File include/v8-profiler.h (right): https://codereview.chromium.org/243033002/diff/1/include/v8-profiler.h#newcode121 include/v8-profiler.h:121: * Returns time when the profile recording was started ...
6 years, 8 months ago (2014-04-18 13:19:58 UTC) #3
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-19 10:11:45 UTC) #4
alph
The CQ bit was checked by alph@chromium.org
6 years, 8 months ago (2014-04-19 12:03:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://v8-status.appspot.com/cq/alph@chromium.org/243033002/20001
6 years, 8 months ago (2014-04-19 12:04:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-19 12:04:10 UTC) #7
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-19 12:04:10 UTC) #8
alph
6 years, 8 months ago (2014-04-19 14:33:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r20866 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698