Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 2430313003: Give better assertion fail message on focus move test (Closed)

Created:
4 years, 2 months ago by kochi
Modified:
4 years, 1 month ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give better assertion fail message on focus move test Old: assert_true: should move from XXX to YYY expected true got false New (actually in one line): assert_equals: Focus should move forward from XXX to YYY expected Element node <input id="YYY"></input> but got Element node <input id="ZZZ"> Committed: https://crrev.com/9f6c0197b19f50d0f634df34df981929aa90c15c Cr-Commit-Position: refs/heads/master@{#427019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/shadow-dom/resources/focus-utils.js View 2 chunks +17 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
kochi
PTAL
4 years, 2 months ago (2016-10-21 06:29:58 UTC) #7
hayato
lgtm
4 years, 1 month ago (2016-10-24 04:57:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430313003/1
4 years, 1 month ago (2016-10-24 05:11:00 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 06:17:34 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 06:19:42 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f6c0197b19f50d0f634df34df981929aa90c15c
Cr-Commit-Position: refs/heads/master@{#427019}

Powered by Google App Engine
This is Rietveld 408576698