Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 243028: Fix encoding of the query part of an URL [Issue 20507]. (Closed)

Created:
11 years, 2 months ago by Roland
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, xlyuan
Visibility:
Public.

Description

Fix encoding of the query part of an URL. Encoding of the query part of an URL was inconsistent: If it was part of a larger relative URL, it would get encoded. However, if the query part was stand-alone, then it would not be encoded. As indicated by the original layout test referenced in the bug (see below), this patch changes the code so that the query part is encoded in both cases. Note, however, that with this patch the layout test will NOT yet fully pass, since it also handles the fragment part differently. As the different handling of the fragment part seems to be quite on purpose, I have not modified the behavior - see the discussion at http://code.google.com/p/chromium/issues/detail?id=20507 . BUG=20507, 8912 TEST=LayoutTests/http/tests/uri/resolve-encoding-relative.html

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/url_canon_relative.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Roland
Hi, I uploaded a small patch that fixes an issue with URL encoding (query part), ...
11 years, 2 months ago (2009-09-28 14:11:33 UTC) #1
brettw
LGTM. Would you prefer me to check this current patch in to googleurl now, or ...
11 years, 2 months ago (2009-09-28 17:05:10 UTC) #2
jungshik at Google
lgtm
11 years, 2 months ago (2009-09-28 18:42:10 UTC) #3
Roland
On 2009/09/28 17:05:10, brettw wrote: > LGTM. Would you prefer me to check this current ...
11 years, 2 months ago (2009-09-29 01:50:03 UTC) #4
jungshik at Google
On 2009/09/29 01:50:03, Roland wrote: > On 2009/09/28 17:05:10, brettw wrote: > > LGTM. Would ...
11 years, 2 months ago (2009-10-19 17:00:30 UTC) #5
brettw
11 years, 2 months ago (2009-10-19 17:21:10 UTC) #6
Sorry, I lost this. I checked it in as googleurl@120. I did not pull DEPS.

Powered by Google App Engine
This is Rietveld 408576698